Page MenuHomePhabricator

[MLIR][Presburger] Remove `spaceKind` from PresburgerSpace
ClosedPublic

Authored by Groverkss on Mar 10 2022, 1:08 AM.

Details

Summary

This patch remove spaceKind from PresburgerSpace, making PresburgerSpace only
a space supporting relations.

Sets are still implemented in the same way, i.e. with a zero domain but instead
the asserts to check if the space is still set are added to users of
PresburgerSpace which treat it as a Set space.

Diff Detail

Event Timeline

Groverkss created this revision.Mar 10 2022, 1:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 1:08 AM
Groverkss requested review of this revision.Mar 10 2022, 1:08 AM
arjunp accepted this revision.Mar 10 2022, 2:07 AM
arjunp added inline comments.
mlir/include/mlir/Analysis/Presburger/PWMAFunction.h
154–155
mlir/lib/Analysis/Presburger/PresburgerSpace.cpp
142–144

PresburgerSpace::print(os) would deduplicate this

This revision is now accepted and ready to land.Mar 10 2022, 2:07 AM
Groverkss updated this revision to Diff 414390.Mar 10 2022, 8:42 AM
Groverkss marked 2 inline comments as done.

Address Arjun's comments

This revision was landed with ongoing or failed builds.Mar 10 2022, 8:50 AM
This revision was automatically updated to reflect the committed changes.