This is an archive of the discontinued LLVM Phabricator instance.

[clang][driver] Fix float128 diagnostics with glibc >= 2.32
ClosedPublic

Authored by tbaeder on Mar 8 2022, 5:25 AM.

Reviewers

Commits

Summary

As explained in https://reviews.llvm.org/D112906#3366874, the check here seems broken and the tests failed when run on a machine with a glibc >= 2.32 installed.

tbaeder requested review of this revision.Mar 8 2022, 5:25 AM

LGTM, thanks for the catch.

This revision is now accepted and ready to land.Mar 8 2022, 6:10 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

lib/

Driver/

ToolChains/

6 lines

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines	bool PPCLinuxToolChain::SupportIEEEFloat128(
const Driver &D, const llvm::Triple &Triple,		const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args) const {		const llvm::opt::ArgList &Args) const {
if (!Triple.isLittleEndian() \|\| !Triple.isPPC64())		if (!Triple.isLittleEndian() \|\| !Triple.isPPC64())
return false;		return false;

if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx))		if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx))
return true;		return true;

		CXXStdlibType StdLib = ToolChain::GetCXXStdlibType(Args);
bool HasUnsupportedCXXLib =		bool HasUnsupportedCXXLib =
ToolChain::GetCXXStdlibType(Args) == CST_Libcxx &&		StdLib == CST_Libcxx \|\|
GCCInstallation.getVersion().isOlderThan(12, 1, 0);		(StdLib == CST_Libstdcxx &&
		GCCInstallation.getVersion().isOlderThan(12, 1, 0));

return GlibcSupportsFloat128(Linux::getDynamicLinker(Args)) &&		return GlibcSupportsFloat128(Linux::getDynamicLinker(Args)) &&
!(D.CCCIsCXX() && HasUnsupportedCXXLib);		!(D.CCCIsCXX() && HasUnsupportedCXXLib);
}		}