This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Pass /winsysroot explicitly
ClosedPublic

Authored by smeenai on Mar 4 2022, 5:12 PM.

Details

Summary

We were relying on HandleLLVMOptions adding this flag, but that's not
included in compiler-rt. Add the flag explicitly ourselves to ensure
it's present; the duplication of the flag in the parts of the build
which do include HandleLLVMOptions doesn't cause any issues.

Diff Detail

Event Timeline

smeenai created this revision.Mar 4 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 5:12 PM
Herald added a subscriber: mgorny. · View Herald Transcript
smeenai requested review of this revision.Mar 4 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 5:12 PM
smeenai updated this revision to Diff 413172.Mar 4 2022, 5:14 PM

Alphabetize the flags

ychen accepted this revision.Mar 4 2022, 8:28 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Mar 4 2022, 8:28 PM
This revision was landed with ongoing or failed builds.Mar 4 2022, 10:28 PM
This revision was automatically updated to reflect the committed changes.