This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][FIX] Ensure custom state machine works
ClosedPublic

Authored by jdoerfert on Mar 4 2022, 10:05 AM.

Details

Summary

The custom state machine had a check for surplus threads that filtered
the main thread if the kernel was executed by a single warp only. We
now first check for the main thread, then for surplus threads, avoiding
to filter the former out.

Fixes #54214.

Diff Detail

Event Timeline

jdoerfert created this revision.Mar 4 2022, 10:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 10:05 AM
jdoerfert requested review of this revision.Mar 4 2022, 10:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 10:05 AM
jdoerfert updated this revision to Diff 413056.Mar 4 2022, 10:06 AM

Fix comment

jhuber6 accepted this revision.Mar 4 2022, 10:10 AM
jhuber6 edited the summary of this revision. (Show Details)

LGTM, fixes the issue and passed tests.

This revision is now accepted and ready to land.Mar 4 2022, 10:12 AM
This revision was landed with ongoing or failed builds.Mar 4 2022, 10:51 AM
This revision was automatically updated to reflect the committed changes.