This is an archive of the discontinued LLVM Phabricator instance.

Differential D121000

[llvm] fix bitcode-strip.test on windows
ClosedPublic

Authored by rmaz on Mar 4 2022, 8:25 AM.

Details

Reviewers
alexander-shaposhnikov
rupprecht
jhenderson
drodriguez
Commits
rG8ba84ceda002: [llvm] fix bitcode-strip.test on windows
Summary

Remove the executable name from the test match as this will have
a .exe suffix on windows.

Diff Detail

Event Timeline

rmaz created this revision.Mar 4 2022, 8:25 AM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptMar 4 2022, 8:25 AM
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
rmaz requested review of this revision.Mar 4 2022, 8:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2022, 8:25 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
rmaz added a reviewer: drodriguez.Mar 4 2022, 8:25 AM
drodriguez accepted this revision.Mar 4 2022, 8:29 AM
This revision is now accepted and ready to land.Mar 4 2022, 8:29 AM
This revision was landed with ongoing or failed builds.Mar 4 2022, 8:31 AM
Closed by commit rG8ba84ceda002: [llvm] fix bitcode-strip.test on windows (authored by rmaz, committed by drodriguez). · Explain Why
This revision was automatically updated to reflect the committed changes.
drodriguez added a commit: rG8ba84ceda002: [llvm] fix bitcode-strip.test on windows.
Harbormaster completed remote builds in B152601: Diff 413021.Mar 4 2022, 9:01 AM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
MachO/
2 lines

Diff 413023

llvm/test/tools/llvm-objcopy/MachO/bitcode-strip.test

## Test output flag is required. ## Test output flag is required.
# RUN: yaml2obj %s -o %t # RUN: yaml2obj %s -o %t
# RUN: not llvm-bitcode-strip %t 2>&1 | FileCheck --check-prefix=MISSING-ARG %s # RUN: not llvm-bitcode-strip %t 2>&1 | FileCheck --check-prefix=MISSING-ARG %s
# RUN: llvm-bitcode-strip %t -o %t2 # RUN: llvm-bitcode-strip %t -o %t2
# RUN: cmp %t %t2 # RUN: cmp %t %t2
# MISSING-ARG: llvm-bitcode-strip: error: -o is a required argument # MISSING-ARG: error: -o is a required argument
--- !mach-o --- !mach-o
FileHeader: FileHeader:
magic: 0xFEEDFACF magic: 0xFEEDFACF
cputype: 0x01000007 cputype: 0x01000007
cpusubtype: 0x00000003 cpusubtype: 0x00000003
filetype: 0x00000001 filetype: 0x00000001
ncmds: 1 ncmds: 1
Show All 29 Lines