This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Split up huge arm-cortex-cpus.c test.
ClosedPublic

Authored by fhahn on Mar 3 2022, 1:17 AM.

Details

Summary

This test file has grown to the point where it takes a huge amount of
time to run. At the moment, this test seems to consistently time out
when running in the pre-commit checks in Phabricator with a 10 minute
timeout. For example see
https://reviews.llvm.org/harbormaster/unit/view/2832724/

While splitting up the test file is not ideal, it is even more
undesirable to have huge test files that time out in common settings.

This patch splits up the test file roughly in the middle.

Diff Detail

Event Timeline

fhahn created this revision.Mar 3 2022, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 1:17 AM
fhahn requested review of this revision.Mar 3 2022, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 1:17 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dmgreen accepted this revision.Mar 3 2022, 11:59 PM

Same as D120875, if anyone wants to split this up more naturally that would be good, but until then this LGTM.

This revision is now accepted and ready to land.Mar 3 2022, 11:59 PM
fhahn updated this revision to Diff 412974.Mar 4 2022, 3:31 AM

Thanks!

I added a TODO to split it up by categories and I'll plan to land the change soon.

This revision was landed with ongoing or failed builds.Mar 4 2022, 3:40 AM
This revision was automatically updated to reflect the committed changes.