This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix gcc -std=c++17 compilation.
ClosedPublic

Authored by Meinersbur on Mar 2 2022, 3:51 PM.

Details

Summary

Ensure that Handler within the class is interpreted as the as the current template instantiation (instead the class template itself).

Fixes #53447

Diff Detail

Event Timeline

Meinersbur created this revision.Mar 2 2022, 3:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2022, 3:51 PM
Meinersbur requested review of this revision.Mar 2 2022, 3:51 PM
rriddle accepted this revision.Mar 2 2022, 4:08 PM
This revision is now accepted and ready to land.Mar 2 2022, 4:08 PM

Thanks!

Nit: if you type in the description Fixes #53447 then it'll close the issue automatically and link the commit to the issue on GitHub.

Meinersbur edited the summary of this revision. (Show Details)Mar 3 2022, 5:16 AM
This revision was landed with ongoing or failed builds.Mar 3 2022, 7:16 AM
This revision was automatically updated to reflect the committed changes.

I think this broke the windows mlir bot: https://lab.llvm.org/buildbot/#/builders/13/builds/17954/steps/6/logs/stdio

Note, it may not be this change, but another related change. The bot was offline for a few days because of a different issue.