This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] [AMDGPU] Use correct flags when building SerializeToHsaco
ClosedPublic

Authored by krzysz00 on Feb 28 2022, 8:12 AM.

Details

Summary

The SerializeToHsaco pass does not depend on ROCm being available on
the build system - it only requires ROCm to be present at runtime.
However, the CMake file that built it tested for
MLIR_ENABLE_ROCM_RUNNER , which implies that ROCm is currently
available and is used to control building ROCm integration tests.

Referencing MLIR_ENABLE_ROCM_RUNNER instead of
MLIR_ENABLE_ROCM_CONVERSIONS in the SerializeToHsaco build therefore
causes problems for clients who wish to build projects that depend on
this pass on a system without an AMD GPU present.

Diff Detail

Event Timeline

krzysz00 created this revision.Feb 28 2022, 8:12 AM
krzysz00 requested review of this revision.Feb 28 2022, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 11:50 AM
whchung accepted this revision.Mar 3 2022, 12:06 PM

LGTM.

This revision is now accepted and ready to land.Mar 3 2022, 12:06 PM
This revision was landed with ongoing or failed builds.Mar 3 2022, 1:44 PM
This revision was automatically updated to reflect the committed changes.