This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][docs] Fix incorrect 'clang-format 12' option markers
ClosedPublic

Authored by kuzkry on Feb 27 2022, 9:16 AM.

Details

Summary

Introduced by 23a5090c6, some style option markers indicated 'clang-format 12',
though their respective options were available in earlier releases.

Diff Detail

Event Timeline

kuzkry requested review of this revision.Feb 27 2022, 9:16 AM
kuzkry created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2022, 9:16 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Here's a list of earliest commits where each option changed in this PR was introduced:

AlignOperands - introduced by 3219e43c9467e47be9b1a9e32b3ed42a50f6b280
AllowShortEnumsOnASingleLine - introduced by 292058a5d6d708ec7d285a452d4350b33ba080dc
IndentExternBlock - introduced by 6ef45b0426a8c7b9764e102fb1a49561a3a2c118
InsertTrailingCommas - introduced by a324fcf1ae62d065b957e66a9d2f5c18b6259d27
ObjCBreakBeforeNestedBlockParam - introduced by 70c98671fa7b395a52829b91782393f4c2613562
WhitespaceSensitiveMacros - introduced by 292058a5d6d708ec7d285a452d4350b33ba080dc

This revision is now accepted and ready to land.Feb 27 2022, 12:05 PM
MyDeveloperDay accepted this revision.Feb 28 2022, 12:13 AM

once again thank you!

once again thank you!

You're welcome :)

Could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek <krystian.kuzniarek@gmail.com>"

Kind reminder, please deliver this one for me.

Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 4:05 AM

Your patches are not directly applicable.
You have

--- clang/include/clang/Format/Format.h
+++ clang/include/clang/Format/Format.h

instead of

--- a/clang/include/clang/Format/Format.h
+++ b/clang/include/clang/Format/Format.h

which results in

$ git apply diff.patch
error: docs/ClangFormatStyleOptions.rst: No such file or directory
error: include/clang/Format/Format.h: No such file or directory
This revision was landed with ongoing or failed builds.Mar 12 2022, 1:56 PM
This revision was automatically updated to reflect the committed changes.