Page MenuHomePhabricator

kuzkry (Krystian Kuzniarek)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2020, 3:46 AM (30 w, 3 d)

Recent Activity

Mar 9 2021

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thank you for delivering it, @HazardyKnusperkeks.

One thing concerns me though. I'm not an author of changes done in clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-3073, 3075, 3077, 3082-3086, 3088, 3093-3097, 3099, 3104-3108, and 3110-3111. Perhaps it's just a mistake (something might have slipped through git add). Please let me know.

I've just run dump_format_style.py, why the other lines were changed (or not correct before) I don't know, but this is the result of the official script.

If that bothers you I can revert and split it in two commits. But I don't think that's necessary as the real author of those lines is the script, not what's written in the git history.

Mar 9 2021, 4:01 PM · Restricted Project, Restricted Project

Mar 2 2021

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thank you for delivering it, @HazardyKnusperkeks.

Mar 2 2021, 7:03 AM · Restricted Project, Restricted Project

Feb 28 2021

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Do you need someone to push it?

Yes, I need someone to do that. I don't have write permissions. I'm new here.

Please state the name and mail for the commit. I will push it for you.

Feb 28 2021, 2:20 PM · Restricted Project, Restricted Project

Feb 27 2021

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Do you need someone to push it?

Yes, I need someone to do that. I don't have write permissions. I'm new here.

Feb 27 2021, 8:15 PM · Restricted Project, Restricted Project

Feb 12 2021

kuzkry added inline comments to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.
Feb 12 2021, 4:22 AM · Restricted Project, Restricted Project
kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Rebased to the tip of the main branch, merged similar tests (requested by @curdeius)

Feb 12 2021, 4:17 AM · Restricted Project, Restricted Project

Feb 10 2021

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Please regroup tests and add release notes.

Feb 10 2021, 6:05 PM · Restricted Project, Restricted Project
kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!)

Feb 10 2021, 5:51 PM · Restricted Project, Restricted Project
kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Rebased to the tip of the main branch, sorted code alphabetically as suggested by @HazardyKnusperkeks and applied almost all fixes proposed by @curdeius (entry in release notes + some changes in unit tests)

Feb 10 2021, 5:47 PM · Restricted Project, Restricted Project

Dec 21 2020

kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Renamed MaxUnwrappedLinesForShortNamespace to ShortNamespaceLines (thank you @MyDeveloperDay for the idea and @curdeius for mentioning clang-tidy). I haven't changed the description of this option so you might wanna complain on that. Tbh. English isn't my native language so I'll take your tips if you wanna help simplify it.

Dec 21 2020, 4:34 PM · Restricted Project, Restricted Project

Dec 19 2020

kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

As proposed by @MyDeveloperDay, I added MaxUnwrappedLinesForShortNamespace option to control behaviour of FixNamespaceComments. This time I'm providing you with a full diff.
Btw. sorry for taking so long.

Dec 19 2020, 8:17 AM · Restricted Project, Restricted Project

Sep 16 2020

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good reviewer. :)
Also, I think you've made some good points there and I'm going to turn this review into "non-breaking the world" one. I'll be back in a few days with a new diff.

Sep 16 2020, 4:24 AM · Restricted Project, Restricted Project

Sep 14 2020

kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Hey @MyDeveloperDay, thanks for the review.

Sep 14 2020, 10:29 AM · Restricted Project, Restricted Project
kuzkry retitled D87587: [clang-format][PR47290] Add ShortNamespaceLines format option from [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation to [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.
Sep 14 2020, 1:21 AM · Restricted Project, Restricted Project
kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thanks @JakeMerdichAMD for your quick feedback.

Sep 14 2020, 1:17 AM · Restricted Project, Restricted Project

Sep 13 2020

kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Formatted code after CI failure.

Sep 13 2020, 11:26 AM · Restricted Project, Restricted Project
kuzkry updated the diff for D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Adjusted tests IncludeFixerTest.cpp after CI failure.

Sep 13 2020, 10:45 AM · Restricted Project, Restricted Project
kuzkry added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

This fixes https://bugs.llvm.org/show_bug.cgi?id=47290.

Sep 13 2020, 4:02 AM · Restricted Project, Restricted Project
kuzkry requested review of D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.
Sep 13 2020, 4:00 AM · Restricted Project, Restricted Project