Page MenuHomePhabricator

avoid constructing an incomplete TTI in InlineCostAnnotationPrinterPass
Needs ReviewPublic

Authored by vtjnash on Feb 25 2022, 10:50 AM.

Details

Reviewers
knaumov
wsmoses
Summary

It is not an essential pass (just printing), but analysis is supposed to come from the FAM, not be constructed here (it is missing the TargetMachine, which would cause it to print the wrong costs).

Diff Detail

Unit TestsFailed

TimeTest
2,050 msx64 debian > Clang.utils/update_cc_test_checks::check-globals.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/check-globals.test.tmp
1,190 msx64 debian > Clang.utils/update_cc_test_checks::global-hex-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-hex-value-regex.test.tmp
1,190 msx64 debian > Clang.utils/update_cc_test_checks::global-value-regex.test
Script: -- : 'RUN: at line 1'; rm -rf /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp && mkdir /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/utils/update_cc_test_checks/Output/global-value-regex.test.tmp
410 msx64 debian > HWAddressSanitizer-x86_64.TestCases/Linux::decorate-proc-maps.c
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -fsanitize-hwaddress-experimental-aliasing -mllvm -hwasan-generate-tags-with-calls=1 -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions -mllvm -hwasan-globals=0 -g /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/hwasan/TestCases/Linux/decorate-proc-maps.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Linux/Output/decorate-proc-maps.c.tmp
59,700 msx64 debian > MLIR.Examples/standalone::test.toy
Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir ; /usr/bin/cmake --build . --target check-standalone | tee /var/lib/buildkite-agent/builds/llvm-project/build/tools/mlir/test/Examples/standalone/Output/test.toy.tmp | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Examples/standalone/test.toy
View Full Test Results (494 Failed)

Event Timeline

vtjnash created this revision.Feb 25 2022, 10:50 AM
vtjnash requested review of this revision.Feb 25 2022, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2022, 10:50 AM
vtjnash edited the summary of this revision. (Show Details)Feb 25 2022, 10:59 AM
vtjnash added reviewers: knaumov, wsmoses.
vtjnash added a subscriber: vchuravy.
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 1:57 PM

bump? this should be an easy obvious bugfix

Since you say it's possible to get the wrong cost, is it possible to create a test case that highlights this?