This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][NFC] Report errors from RewriteInstance `discoverStorage` and `run`
ClosedPublic

Authored by Amir on Feb 20 2022, 5:43 PM.

Details

Summary

Further improve error handling in BOLT by reporting RewriteInstance errors in
a library and fuzzer-friendly way instead of exiting.

Follow-up to D119658

Diff Detail

Event Timeline

Amir created this revision.Feb 20 2022, 5:43 PM
Amir requested review of this revision.Feb 20 2022, 5:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2022, 5:43 PM
Amir updated this revision to Diff 410207.Feb 20 2022, 7:36 PM

Turn assert into error

rafauler accepted this revision.Feb 23 2022, 6:24 PM

LGTM. One nit below.

bolt/lib/Rewrite/RewriteInstance.cpp
757
This revision is now accepted and ready to land.Feb 23 2022, 6:24 PM
Amir updated this revision to Diff 410995.Feb 23 2022, 7:33 PM

Address nit

Amir marked an inline comment as done.Feb 23 2022, 7:53 PM