llvm/Support/Error.h and llvm/ADT/ArrayRef.h were identified as quiet heavy by clang build analyzer.
Removing includes and forward declaring the relevant classes saves compilation time
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D120208
[tools] Forward declare classes & remove includes ClosedPublic Authored by clemenswasser on Feb 20 2022, 6:24 AM.
Details Summary llvm/Support/Error.h and llvm/ADT/ArrayRef.h were identified as quiet heavy by clang build analyzer.
Diff Detail Event TimelineThis revision is now accepted and ready to land.Feb 23 2022, 4:01 PM
This revision was landed with ongoing or failed builds.Jun 3 2022, 4:32 PM Closed by commit rG42c7f494d93f: [tools] Forward declare classes & remove includes (authored by clemenswasser, committed by MaskRay). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 410145 llvm/tools/dsymutil/Reproducer.h
llvm/tools/llvm-exegesis/lib/PerfHelper.h
llvm/tools/llvm-ifs/ErrorCollector.h
llvm/tools/llvm-mca/Views/InstructionView.h
llvm/tools/llvm-pdbutil/LinePrinter.h
llvm/tools/llvm-pdbutil/OutputStyle.h
llvm/tools/llvm-reduce/DeltaManager.cpp
llvm/tools/llvm-reduce/ReducerWorkItem.h
llvm/tools/llvm-reduce/ReducerWorkItem.cpp
llvm/tools/llvm-reduce/TestRunner.hllvm/tools/llvm-reduce/TestRunner.cpp
llvm/tools/llvm-reduce/deltas/Delta.h
llvm/tools/llvm-reduce/deltas/Delta.cpp
llvm/tools/llvm-reduce/deltas/ReduceInstructionsMIR.cpp
llvm/tools/llvm-reduce/llvm-reduce.cpp
llvm/tools/opt/NewPMDriver.h
|
This needs to be retained. I'll fix it.