[clangd] Tweak --query-driver to ignore slash direction on windows

[sammccall]

Summary

See https://github.com/clangd/clangd/issues/1022

[kadircet]

thanks, lgtm!

clang-tools-extra/clangd/QueryDriverDatabase.cpp

278

nit: maybe extract llvm::sys::path::is_separator('/') && llvm::sys::path::is_separator('\\') into a bool PlatformIsSlashInsensitive ?

298

we don't know the FS .. ?

[sammccall]

clang-tools-extra/clangd/QueryDriverDatabase.cpp

278

We require the separators to be exactly \ and / for the regex to be correct, so I'd rather keep the literals here.

(Call me paranoid, but I grew up on a system with : for separators...)

clang-tools-extra/clangd/QueryDriverDatabase.cpp

 #include "support/Logger.h"
 #include "support/Path.h"
 #include "support/Trace.h"
 #include "clang/Basic/Diagnostic.h"
 #include "clang/Basic/TargetInfo.h"
 #include "clang/Basic/TargetOptions.h"
 #include "clang/Driver/Types.h"
 #include "clang/Tooling/CompilationDatabase.h"
-#include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/iterator_range.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/Program.h"
 #include "llvm/Support/Regex.h"
 #include "llvm/Support/ScopedPrinter.h"
 #include <algorithm>
 #include <map>
if (Glob[I] == '*') {
         // Double star, accept any sequence.
         RegStream << ".*";
         // Also skip the second star.
         ++I;
       } else {
         // Single star, accept any sequence without a slash.
         RegStream << "[^/]*";
       }
+    } else if (llvm::sys::path::is_separator(Glob[I]) &&
+               llvm::sys::path::is_separator('/') &&
+               llvm::sys::path::is_separator('\\')) {
+      RegStream << R"([/\\])"; // Accept either slash on windows.
     } else {
       RegStream << llvm::Regex::escape(Glob.substr(I, 1));
     }
   }
   RegStream << '$';
   RegStream.flush();
   return RegText;
 }
 
 /// Converts a glob containing only ** or * into a regex.
 llvm::Regex convertGlobsToRegex(llvm::ArrayRef<std::string> Globs) {
   assert(!Globs.empty() && "Globs cannot be empty!");
   std::vector<std::string> RegTexts;
   RegTexts.reserve(Globs.size());
   for (llvm::StringRef Glob : Globs)
     RegTexts.push_back(convertGlobToRegex(Glob));
 
+  // Tempting to pass IgnoreCase, but we don't know the FS sensitivity.
   llvm::Regex Reg(llvm::join(RegTexts, "|"));
   assert(Reg.isValid(RegTexts.front()) &&
          "Created an invalid regex from globs");
   return Reg;
 }
 
 /// Extracts system includes from a trusted driver by parsing the output of
 /// include search path and appends them to the commands coming from underlying