This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Fix atomic instructions operands sequence
ClosedPublic

Authored by SixWeining on Feb 17 2022, 7:23 PM.

Details

Summary

According to https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#atomic-memory-access-instructions,
the operands sequence of am* instructions should be "rd, rk, rj"
but not "rd, rj, rk". Sorry for this typo in initial patches.

Diff Detail

Event Timeline

SixWeining created this revision.Feb 17 2022, 7:23 PM
SixWeining requested review of this revision.Feb 17 2022, 7:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2022, 7:23 PM
xen0n accepted this revision.Feb 18 2022, 7:39 AM

Here we are again, you're bitten by the inconsistent manual syntax, and I didn't notice because everything in the initial patch seemed perfectly symmetrical ;-)

This revision is now accepted and ready to land.Feb 18 2022, 7:39 AM
MaskRay accepted this revision.Feb 18 2022, 1:47 PM

Here we are again, you're bitten by the inconsistent manual syntax, and I didn't notice because everything in the initial patch seemed perfectly symmetrical ;-)

Yes. This is indeed a typical example. :(

This revision was automatically updated to reflect the committed changes.