This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Propagate NaNs in PolynomialApproximation
ClosedPublic

Authored by tpopp on Feb 17 2022, 1:23 AM.

Details

Summary

Previously, NaNs would be dropped in favor of bounded values which was
strictly incorrect. Now the min/max operation propagate this
information. Not all uses of min/max need this, but the given change
will help protect future additions, and this prevents the need for an
additional cmpf and select operation to handle NaNs.

Diff Detail

Event Timeline

tpopp created this revision.Feb 17 2022, 1:23 AM
tpopp requested review of this revision.Feb 17 2022, 1:23 AM
tpopp updated this revision to Diff 409545.Feb 17 2022, 1:42 AM

Update test cases

akuegel accepted this revision.Feb 17 2022, 1:45 AM
This revision is now accepted and ready to land.Feb 17 2022, 1:45 AM
rsuderman accepted this revision.Feb 17 2022, 10:47 AM