This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Allow .data shorthand for .section .data.0,"",@
ClosedPublic

Authored by aardappel on Feb 14 2022, 3:56 PM.

Details

Reviewers
dschuff
sbc100

Diff Detail

Event Timeline

aardappel created this revision.Feb 14 2022, 3:56 PM
aardappel requested review of this revision.Feb 14 2022, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 3:56 PM
sbc100 added inline comments.Feb 14 2022, 4:18 PM
llvm/lib/MC/MCParser/WasmAsmParser.cpp
97

Looking at how this works in ELF it looks like it just calls ELFAsmParser::ParseSectionSwitch which doesn't need a name at all. What happens if you just skip the name and call getWasmSection without a name? I think it should just find the default data section which is probably what we want.

aardappel marked an inline comment as done.

Addressed comment

sbc100 accepted this revision.Feb 22 2022, 10:25 AM
This revision is now accepted and ready to land.Feb 22 2022, 10:25 AM
aardappel closed this revision.Feb 22 2022, 10:28 AM

Forgot the Differential Revision: , it has been pushed to main.