The patch implements microMIPS32r6 and microMIPS64r6 ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt, MADDF.fmt, MSUBF.fmt and NEG.fmt instructions.
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D11978
[mips][microMIPS] Implement ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt, MADDF.fmt, MSUBF.fmt and NEG.fmt instructions ClosedPublic Authored by zbuljan on Aug 12 2015, 4:28 AM.
Details Summary The patch implements microMIPS32r6 and microMIPS64r6 ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt, MADDF.fmt, MSUBF.fmt and NEG.fmt instructions.
Diff Detail Event Timelinezbuljan retitled this revision from to [mips][microMIPS] Implement ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt, MADDF.fmt, MSUBF.fmt and NEG.fmt instructions. zbuljan updated this object. This revision is now accepted and ready to land.Aug 21 2015, 6:16 AM Closed by commit rL246919: [mips][microMIPS] Implement ADD.fmt, SUB.fmt, MOV.fmt, MUL.fmt, DIV.fmt… (authored by zjovanovic). · Explain WhySep 5 2015, 2:26 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 31925 lib/Target/Mips/MicroMips32r6InstrFormats.td
lib/Target/Mips/MicroMips32r6InstrInfo.td
lib/Target/Mips/Mips32r6InstrInfo.td
test/MC/Disassembler/Mips/micromips32r6.txt
test/MC/Disassembler/Mips/micromips64r6.txt
test/MC/Mips/micromips32r6/valid.s
test/MC/Mips/micromips64r6/valid.s
|
Two nits:
Indentation of line 300. Arguments should be fully hanging or next line should be aligned to first argument.
There should be a space before the '='