This is an archive of the discontinued LLVM Phabricator instance.

Differential D119733

[BOLT] Fix aarch64 dwarf test
ClosedPublic

Authored by yota9 on Feb 14 2022, 9:13 AM.

Details

Reviewers
maksfb
rafauler
Amir
ayermolo
Commits
rGeccdf2d9b128: [BOLT] Fix aarch64 dwarf test
Summary

After "Remove caching of ranges/abbrevs" patch the dwarf offsets are a
bit changed and the subprograms high pc is replaced with AT_RANGES.

Diff Detail

Event Timeline

yota9 created this revision.Feb 14 2022, 9:13 AM
Herald added subscribers: ayermolo, kristof.beyls. · View Herald TranscriptFeb 14 2022, 9:13 AM
yota9 requested review of this revision.Feb 14 2022, 9:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 9:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yota9 added a reviewer: ayermolo.Feb 14 2022, 9:18 AM
yota9 removed a subscriber: ayermolo.
Harbormaster completed remote builds in B149406: Diff 408448.Feb 14 2022, 9:19 AM
rafauler accepted this revision.Feb 14 2022, 2:55 PM

LGTM

This revision is now accepted and ready to land.Feb 14 2022, 2:55 PM
Closed by commit rGeccdf2d9b128: [BOLT] Fix aarch64 dwarf test (authored by yota9). · Explain WhyFeb 15 2022, 3:00 AM
This revision was automatically updated to reflect the committed changes.
yota9 added a commit: rGeccdf2d9b128: [BOLT] Fix aarch64 dwarf test.

Revision Contents

PathSize
bolt/
test/
AArch64/
9 lines

Diff 408791

bolt/test/AArch64/go_dwarf.test

Show All 18 Lines
CHECKORIG-NEXT: DW_AT_low_pc (0x0000000000000660) CHECKORIG-NEXT: DW_AT_low_pc (0x0000000000000660)
CHECKORIG: DW_TAG_subprogram CHECKORIG: DW_TAG_subprogram
CHECKORIG-NEXT: DW_AT_external (true) CHECKORIG-NEXT: DW_AT_external (true)
CHECKORIG-NEXT: DW_AT_name ("main") CHECKORIG-NEXT: DW_AT_name ("main")
CHECKORIG-NEXT: DW_AT_decl_file CHECKORIG-NEXT: DW_AT_decl_file
CHECKORIG-NEXT: DW_AT_decl_line (1) CHECKORIG-NEXT: DW_AT_decl_line (1)
CHECKORIG-NEXT: DW_AT_decl_column (0x05) CHECKORIG-NEXT: DW_AT_decl_column (0x05)
CHECKORIG-NEXT: DW_AT_type (0x00000090 "int") CHECKORIG-NEXT: DW_AT_type
CHECKORIG-NEXT: DW_AT_low_pc (0x0000000000000660) CHECKORIG-NEXT: DW_AT_low_pc (0x0000000000000660)
CHECKORIG-NEXT: DW_AT_high_pc (0x0000000000000684) CHECKORIG-NEXT: DW_AT_high_pc (0x0000000000000684)
# Check the bolted binary. # Check the bolted binary.
RUN: llvm-dwarfdump -debug-info %t.bolt |& FileCheck %s RUN: llvm-dwarfdump -debug-info %t.bolt |& FileCheck %s
CHECK: DW_TAG_compile_unit CHECK: DW_TAG_compile_unit
CHECK-NEXT: DW_AT_producer CHECK-NEXT: DW_AT_producer
CHECK-NEXT: DW_AT_language CHECK-NEXT: DW_AT_language
CHECK-NEXT: DW_AT_name CHECK-NEXT: DW_AT_name
CHECK-NEXT: DW_AT_comp_dir CHECK-NEXT: DW_AT_comp_dir
CHECK-NEXT: DW_AT_ranges (0x00000010 CHECK-NEXT: DW_AT_ranges (0x00000010
CHECK-NEXT: [0x0000000000000660, 0x0000000000000684)) CHECK-NEXT: [0x0000000000000660, 0x0000000000000684))
CHECK-NEXT: DW_AT_low_pc (0x0000000000000000) CHECK-NEXT: DW_AT_low_pc (0x0000000000000000)
CHECK-NEXT: DW_AT_stmt_list (0x00000000) CHECK-NEXT: DW_AT_stmt_list (0x00000000)
CHECK: DW_TAG_subprogram CHECK: DW_TAG_subprogram
CHECK-NEXT: DW_AT_external (true) CHECK-NEXT: DW_AT_external (true)
CHECK-NEXT: DW_AT_name ("main") CHECK-NEXT: DW_AT_name ("main")
CHECK-NEXT: DW_AT_decl_file CHECK-NEXT: DW_AT_decl_file
CHECK-NEXT: DW_AT_decl_line (1) CHECK-NEXT: DW_AT_decl_line (1)
CHECK-NEXT: DW_AT_decl_column (0x05) CHECK-NEXT: DW_AT_decl_column (0x05)
CHECK-NEXT: DW_AT_type (0x00000090 "int") CHECK-NEXT: DW_AT_type
CHECK-NEXT: DW_AT_low_pc (0x0000000000000660) CHECK-NEXT: DW_AT_low_pc (0x0000000000000000)
CHECK-NEXT: DW_AT_high_pc (0x0000000000000684) CHECK-NEXT: DW_AT_ranges (0x00000030
CHECK-NEXT: [0x0000000000000660, 0x0000000000000684))