This is an archive of the discontinued LLVM Phabricator instance.

Differential D119673

[BOLT] Skip warning message if no functions were ignored
ClosedPublic

Authored by maksfb on Feb 13 2022, 11:07 AM.

Details

Reviewers
yota9
rafauler
Amir
ayermolo
Commits
rG641e92d46b2a: [BOLT] Skip warning message if no functions were ignored

Diff Detail

Event Timeline

maksfb requested review of this revision.Feb 13 2022, 11:07 AM
maksfb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2022, 11:07 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yota9 accepted this revision.Feb 13 2022, 11:12 AM

LGTM

This revision is now accepted and ready to land.Feb 13 2022, 11:12 AM
Harbormaster completed remote builds in B149289: Diff 408282.Feb 13 2022, 11:16 AM
Amir accepted this revision.Feb 13 2022, 11:50 AM
Closed by commit rG641e92d46b2a: [BOLT] Skip warning message if no functions were ignored (authored by maksfb). · Explain WhyFeb 14 2022, 10:32 AM
This revision was automatically updated to reflect the committed changes.
maksfb added a commit: rG641e92d46b2a: [BOLT] Skip warning message if no functions were ignored.

Revision Contents

PathSize
bolt/
lib/
Core/
6 lines
test/
X86/
2 lines

Diff 408495

bolt/lib/Core/BinaryContext.cpp

Show First 20 Lines • Show All 706 Lines • ▼ Show 20 Lines assert(UniqueFunctions.count(BF) &&
"internal error in traversing function fragments"); "internal error in traversing function fragments");
if (opts::Verbosity >= 1) if (opts::Verbosity >= 1)
errs() << "BOLT-WARNING: Ignoring " << BF->getPrintName() << '\n'; errs() << "BOLT-WARNING: Ignoring " << BF->getPrintName() << '\n';
BF->setIgnored(); BF->setIgnored();
std::for_each(BF->Fragments.begin(), BF->Fragments.end(), addToWorklist); std::for_each(BF->Fragments.begin(), BF->Fragments.end(), addToWorklist);
std::for_each(BF->ParentFragments.begin(), BF->ParentFragments.end(), std::for_each(BF->ParentFragments.begin(), BF->ParentFragments.end(),
addToWorklist); addToWorklist);
} }
errs() << "BOLT-WARNING: Ignored " << FragmentsToSkip.size() << " functions " if (!FragmentsToSkip.empty())
<< "due to cold fragments.\n"; errs() << "BOLT-WARNING: ignored " << FragmentsToSkip.size() << " function"
<< (FragmentsToSkip.size() == 1 ? "" : "s")
<< " due to cold fragments\n";
FragmentsToSkip.clear(); FragmentsToSkip.clear();
} }
MCSymbol *BinaryContext::getOrCreateGlobalSymbol(uint64_t Address, Twine Prefix, MCSymbol *BinaryContext::getOrCreateGlobalSymbol(uint64_t Address, Twine Prefix,
uint64_t Size, uint64_t Size,
uint16_t Alignment, uint16_t Alignment,
unsigned Flags) { unsigned Flags) {
auto Itr = BinaryDataMap.find(Address); auto Itr = BinaryDataMap.find(Address);
▲ Show 20 Lines • Show All 1,386 Lines • Show Last 20 Lines

bolt/test/X86/split-func-icf.s

Show All 10 Lines
# RUN: llvm-bolt %t.exe -o %t.out -lite=0 -v=1 2>&1 | FileCheck %s # RUN: llvm-bolt %t.exe -o %t.out -lite=0 -v=1 2>&1 | FileCheck %s
# CHECK-NOT: unclaimed PC-relative relocations left in data # CHECK-NOT: unclaimed PC-relative relocations left in data
# CHECK-DAG: BOLT-INFO: marking main2.cold.1(*2) as a fragment of main # CHECK-DAG: BOLT-INFO: marking main2.cold.1(*2) as a fragment of main
# CHECK-DAG: BOLT-INFO: marking main2.cold.1(*2) as a fragment of main2 # CHECK-DAG: BOLT-INFO: marking main2.cold.1(*2) as a fragment of main2
# CHECK-DAG: BOLT-WARNING: Ignoring main2 # CHECK-DAG: BOLT-WARNING: Ignoring main2
# CHECK-DAG: BOLT-WARNING: Ignoring main # CHECK-DAG: BOLT-WARNING: Ignoring main
# CHECK-DAG: BOLT-WARNING: Ignoring main2.cold.1(*2) # CHECK-DAG: BOLT-WARNING: Ignoring main2.cold.1(*2)
# CHECK: BOLT-WARNING: Ignored 3 functions due to cold fragments. # CHECK: BOLT-WARNING: ignored 3 functions due to cold fragments
.text .text
.globl main .globl main
.type main, %function .type main, %function
.p2align 2 .p2align 2
main: main:
LBB0: LBB0:
andl $0xf, %ecx andl $0xf, %ecx
cmpb $0x4, %cl cmpb $0x4, %cl
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines