This is an archive of the discontinued LLVM Phabricator instance.

Differential D119393

[test] Rework memaccess-clobber.ll
ClosedPublic

Authored by aeubanks on Feb 9 2022, 5:06 PM.

Details

Reviewers
ctetreau
fmayer
Commits
rGbe2227b6c7af: [hwasan][test] Rework memaccess-clobber.ll
Summary

Previously memaccess-clobber.ll relied on both legacy PM-specific things
like -analyze and MemoryDependenceAnalysis, which are both deprecated.

This uses MemorySSA, which is the cool new thing that a bunch of passes
have migrated to.

Diff Detail

Unit TestsFailed

TimeTest
60,020 msx64 debian > MLIR.Examples/standalone::test.toy
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,060 msx64 debian > libFuzzer.libFuzzer::large.test
60,030 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

aeubanks created this revision.Feb 9 2022, 5:06 PM
Herald added a reviewer: ctetreau. · View Herald TranscriptFeb 9 2022, 5:06 PM
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added subscribers: asbirlea, george.burgess.iv. · View Herald Transcript
aeubanks requested review of this revision.Feb 9 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 5:06 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks added a reviewer: fmayer.Feb 9 2022, 5:06 PM
aeubanks mentioned this in D107901: [hwasan] Prevent reordering of tag checks..
fmayer accepted this revision.Feb 9 2022, 5:18 PM

thanks a lot!

nit: maybe add [hwasan] to title

This revision is now accepted and ready to land.Feb 9 2022, 5:18 PM
Harbormaster completed remote builds in B148630: Diff 407354.Feb 9 2022, 7:20 PM
This revision was landed with ongoing or failed builds.Feb 10 2022, 9:14 AM
Closed by commit rGbe2227b6c7af: [hwasan][test] Rework memaccess-clobber.ll (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGbe2227b6c7af: [hwasan][test] Rework memaccess-clobber.ll.

Revision Contents

PathSize
llvm/
test/
Instrumentation/
HWAddressSanitizer/
13 lines

Diff 407354

llvm/test/Instrumentation/HWAddressSanitizer/memaccess-clobber.ll

; Make sure memaccess checks preceed the following reads. ; Make sure memaccess checks preceed the following reads.
; ;
; RUN: opt < %s -S -enable-new-pm=0 -hwasan -hwasan-use-stack-safety=0 -basic-aa -memdep -print-memdeps -analyze -mtriple aarch64-linux-android30 | FileCheck %s ; RUN: opt < %s -disable-output 2>&1 -passes='hwasan,print<memoryssa>' -hwasan-use-stack-safety=0 -mtriple aarch64-linux-android30 | FileCheck %s
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128" target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
target triple = "aarch64--linux-android10000" target triple = "aarch64--linux-android10000"
declare void @use32(i32*) declare void @use32(i32*)
define i32 @test_alloca() sanitize_hwaddress { define i32 @test_alloca() sanitize_hwaddress {
entry: entry:
%x = alloca i32, align 4 %x = alloca i32, align 4
; CHECK: call void @use32
call void @use32(i32* nonnull %x) call void @use32(i32* nonnull %x)
; CHECK: Clobber from: call void @llvm.hwasan.check.memaccess.shortgranule ; CHECK: [[A:[0-9]+]] = MemoryDef({{[0-9]+}})
; CHECK-NEXT: load i32, i32* %x.hwasan, align 4 ; CHECK-NEXT: call void @llvm.hwasan.check.memaccess.shortgranules
; CHECK: MemoryUse([[A]])
; CHECK-NEXT: load i32, i32* %x.hwasan
%y = load i32, i32* %x %y = load i32, i32* %x
; CHECK: Clobber from: %y = load i32, i32* %x.hwasan, align 4 ; CHECK: {{[0-9]+}} = MemoryDef([[A]])
; CHECK-NEXT: call void @llvm.memset.p0i8.i64(i8* align 1 {{.*}}, i8 0, i64 1, i1 false) ; CHECK-NEXT: call void @llvm.memset.p0i8.i64
ret i32 %y ret i32 %y
} }