This is an archive of the discontinued LLVM Phabricator instance.

Differential D119183

[libc][Obvious] Suppress unused-variable warnings from syscall_unittest.
ClosedPublic

Authored by lntue on Feb 7 2022, 12:56 PM.

Download Raw Diff

Details

Reviewers

abrachet
michaelrj
sivachandra

Commits

rG57532188526c: [libc][Obvious] Suppress unused-variable warnings from syscall_unittest.

Summary

The unused vararibles in the tests are intentional.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

lntue created this revision.Feb 7 2022, 12:56 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 12:56 PM

Herald added subscribers: ecnelises, tschuett, mgorny. · View Herald Transcript

lntue requested review of this revision.Feb 7 2022, 12:56 PM

Harbormaster completed remote builds in B148081: Diff 406581.Feb 7 2022, 1:01 PM

sivachandra accepted this revision.Feb 7 2022, 1:14 PM

sivachandra added inline comments.

libc/test/src/__support/OSUtil/linux/x86_64/CMakeLists.txt
8	Add a comment here as to why this is present.

This revision is now accepted and ready to land.Feb 7 2022, 1:14 PM

lntue marked an inline comment as done.Feb 7 2022, 1:21 PM

Closed by commit rG57532188526c: [libc][Obvious] Suppress unused-variable warnings from syscall_unittest. (authored by lntue). · Explain WhyFeb 7 2022, 1:22 PM

This revision was automatically updated to reflect the committed changes.

lntue added a commit: rG57532188526c: [libc][Obvious] Suppress unused-variable warnings from syscall_unittest..

Revision Contents

Path

Size

libc/

test/

src/

__support/

OSUtil/

linux/

x86_64/

4 lines

Diff 406591

libc/test/src/__support/OSUtil/linux/x86_64/CMakeLists.txt

	add_libc_unittest(			add_libc_unittest(
	syscall_unittest			syscall_unittest
	SUITE libc_osutil_tests			SUITE libc_osutil_tests
	SRCS syscall_test.cpp			SRCS syscall_test.cpp
	DEPENDS			DEPENDS
	libc.src.__support.OSUtil.osutil			libc.src.__support.OSUtil.osutil
				COMPILE_OPTIONS
				-Wno-unused-variable # Only signature tests, declared variables are unused.
				sivachandraUnsubmitted Done Reply Inline Actions Add a comment here as to why this is present. sivachandra: Add a comment here as to why this is present.
	)			)