This brings the mingw build back to zero build warnings as it was
at some earlier time.
Details
- Reviewers
ldionne Mordante • Quuxplusone - Group Reviewers
Restricted Project - Commits
- rG8cffea061afc: [libcxx] Silence -Wformat-nonliteral warnings in the Windows support code
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Would it make sense to turn these warnings into errors when building the library? That way we can never regress.
For building in CI configurations, I think it would make sense to tighten down as many configurations as possible with -Werror, to avoid regressing something that has been clean at some point. For non-CI builds, I don't think we should be building with -Werror by default though.
(The clang-cl builds are incredibly noisy these days, though, due to [[no_unique_address]] not being recognized in MSVC mode - I haven't had time to bring that issue up, and I'm not sure if we want to wrap the attribute in a macro or not.)
libcxx/src/support/win32/locale_win32.cpp | ||
---|---|---|
100 | Yes, maybe - I was hoping to backport this to 14.x to silence the build there too, so then it'd depend on whether that one (which is a bit bigger) is deemed OK to backport. |
libcxx/utils/ci/run-buildbot | ||
---|---|---|
604 ↗ | (On Diff #407456) | Would you be OK with moving it to the CMake cache instead? |
libcxx/utils/ci/run-buildbot | ||
---|---|---|
604 ↗ | (On Diff #407456) | I think I’d omit this from this particular patch, and once D119430 lands, I’d make a different patch for enabling LIBCXX_ENABLE_WERROR - which would be opt-out for the few configs that don’t pass in that mode. But let’s move that to a later discussion. |
I just noticed D119295 so maybe use the macros added there before landing. (Assuming that patch will be accepted.)