Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/Vector/IR/VectorOps.cpp | ||
---|---|---|
1830 | nit: type shouldn't change. Can you just use getVectorType() instead? |
Paths
| Differential D119032
[mlir][vector] Add constant folder for vector.shuffle ops ClosedPublic Authored by antiagainst on Feb 4 2022, 12:34 PM.
Details
Diff Detail
Event TimelineThomasRaoux added inline comments.
This revision is now accepted and ready to land.Feb 4 2022, 1:17 PM Closed by commit rG9dd4c2dcb63a: [mlir][vector] Add constant folder for vector.shuffle ops (authored by antiagainst). · Explain WhyFeb 4 2022, 1:59 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 406100 mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
mlir/lib/Dialect/Vector/IR/VectorOps.cpp
mlir/test/Dialect/Vector/canonicalize.mlir
|
nit: type shouldn't change. Can you just use getVectorType() instead?