This is an archive of the discontinued LLVM Phabricator instance.

Differential D119014

[BOLT][TEST] Add section flags for .gcc_except_table
ClosedPublic

Authored by Amir on Feb 4 2022, 9:38 AM.

Details

Reviewers
maksfb
rafauler
yota9
Commits
rGd36bd0857289: [BOLT][TEST] Add section flags for .gcc_except_table
Summary

clang-10 complains about changed section flags in two tests:

  • X86/shrinkwrapping.test
  • X86/exceptions-args.test

Fix that by adding the missing flags.

Diff Detail

Event Timeline

Amir created this revision.Feb 4 2022, 9:38 AM
Herald added subscribers: ayermolo, pengfei. · View Herald TranscriptFeb 4 2022, 9:38 AM
Amir requested review of this revision.Feb 4 2022, 9:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 9:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yota9 accepted this revision.Feb 4 2022, 9:41 AM

LGTM

This revision is now accepted and ready to land.Feb 4 2022, 9:41 AM
This revision was landed with ongoing or failed builds.Feb 4 2022, 9:48 AM
Closed by commit rGd36bd0857289: [BOLT][TEST] Add section flags for .gcc_except_table (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rGd36bd0857289: [BOLT][TEST] Add section flags for .gcc_except_table.
Harbormaster completed remote builds in B147661: Diff 406011.Feb 4 2022, 9:56 AM

Revision Contents

PathSize
bolt/
test/
X86/
Inputs/
4 lines
4 lines

Diff 406015

bolt/test/X86/Inputs/exc4sw.S

Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Lines.L13:
je .L12 je .L12
.LEHB3: .LEHB3:
call _Unwind_Resume call _Unwind_Resume
.L12: .L12:
call __cxa_call_unexpected call __cxa_call_unexpected
.LEHE3: .LEHE3:
.cfi_endproc .cfi_endproc
.LFE14: .LFE14:
.section .gcc_except_table .section .gcc_except_table,"a",@progbits
.align 4 .align 4
.LLSDA14: .LLSDA14:
.byte 0xff .byte 0xff
.byte 0x3 .byte 0x3
.uleb128 .LLSDATT14-.LLSDATTD14 .uleb128 .LLSDATT14-.LLSDATTD14
.LLSDATTD14: .LLSDATTD14:
.byte 0x1 .byte 0x1
.uleb128 .LLSDACSE14-.LLSDACSB14 .uleb128 .LLSDACSE14-.LLSDACSB14
▲ Show 20 Lines • Show All 176 Lines • ▼ Show 20 Lines.L43:
movq %rbx, %rdi movq %rbx, %rdi
.L46: .L46:
.LEHB14: .LEHB14:
call _Unwind_Resume call _Unwind_Resume
jmp .L43 jmp .L43
.LEHE14: .LEHE14:
.cfi_endproc .cfi_endproc
.LFE15: .LFE15:
.section .gcc_except_table .section .gcc_except_table,"a",@progbits
.align 4 .align 4
.LLSDA15: .LLSDA15:
.byte 0xff .byte 0xff
.byte 0x3 .byte 0x3
.uleb128 .LLSDATT15-.LLSDATTD15 .uleb128 .LLSDATT15-.LLSDATTD15
.LLSDATTD15: .LLSDATTD15:
.byte 0x1 .byte 0x1
.uleb128 .LLSDACSE15-.LLSDACSB15 .uleb128 .LLSDACSE15-.LLSDACSB15
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines

bolt/test/X86/Inputs/exc_args.s

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines.L10:
call __cxa_call_unexpected call __cxa_call_unexpected
.LEHE3: .LEHE3:
.L12: .L12:
popq %rbp popq %rbp
.cfi_def_cfa 7, 8 .cfi_def_cfa 7, 8
ret ret
.cfi_endproc .cfi_endproc
.LFE17: .LFE17:
.section .gcc_except_table .section .gcc_except_table,"a",@progbits
.align 4 .align 4
.LLSDA17: .LLSDA17:
.byte 0xff .byte 0xff
.byte 0x3 .byte 0x3
.uleb128 .LLSDATT17-.LLSDATTD17 .uleb128 .LLSDATT17-.LLSDATTD17
.LLSDATTD17: .LLSDATTD17:
.byte 0x1 .byte 0x1
.uleb128 .LLSDACSE17-.LLSDACSB17 .uleb128 .LLSDACSE17-.LLSDACSB17
▲ Show 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
.LEHE10: .LEHE10:
.L31: .L31:
movq -8(%rbp), %rbx movq -8(%rbp), %rbx
leave leave
.cfi_def_cfa 7, 8 .cfi_def_cfa 7, 8
ret ret
.cfi_endproc .cfi_endproc
.LFE18: .LFE18:
.section .gcc_except_table .section .gcc_except_table,"a",@progbits
.align 4 .align 4
.LLSDA18: .LLSDA18:
.byte 0xff .byte 0xff
.byte 0x3 .byte 0x3
.uleb128 .LLSDATT18-.LLSDATTD18 .uleb128 .LLSDATT18-.LLSDATTD18
.LLSDATTD18: .LLSDATTD18:
.byte 0x1 .byte 0x1
.uleb128 .LLSDACSE18-.LLSDACSB18 .uleb128 .LLSDACSE18-.LLSDACSB18
▲ Show 20 Lines • Show All 141 Lines • Show Last 20 Lines