This is an archive of the discontinued LLVM Phabricator instance.

Differential D118982

[flang] Add test for quiet with local variable in STOP stmt
ClosedPublic

Authored by clementval on Feb 4 2022, 2:58 AM.

Download Raw Diff

Details

Reviewers

schweitz
kiranchandramohan
jeanPerier
sscalpone
svedanayagam

Commits

rG6518c40931e3: [flang] Add test for quiet with local variable in STOP stmt

Summary

Add a test for the quiet argument in STOP statement that use a local variable instead of a constant.

This allows to test D118978.

This patch is part of the upstreaming effort from fir-dev branch.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

clementval created this revision.Feb 4 2022, 2:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 2:58 AM

clementval requested review of this revision.Feb 4 2022, 2:58 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 2:58 AM

Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript

clementval edited the summary of this revision. (Show Details)Feb 4 2022, 2:59 AM

clementval added reviewers: schweitz, kiranchandramohan, jeanPerier, sscalpone, svedanayagam.

clementval mentioned this in D118978: [flang] Basic local variable lowering.Feb 4 2022, 3:02 AM

Harbormaster completed remote builds in B147589: Diff 405906.Feb 4 2022, 3:15 AM

kiranchandramohan added inline comments.Feb 4 2022, 5:09 AM

flang/test/Lower/stop-statement.f90
48	Can you check for the alloca also?

Update test to check alloca as well

Harbormaster completed remote builds in B147607: Diff 405933.Feb 4 2022, 5:51 AM

jeanPerier accepted this revision.Feb 4 2022, 6:05 AM

This revision is now accepted and ready to land.Feb 4 2022, 6:05 AM

kiranchandramohan accepted this revision.Feb 4 2022, 6:13 AM

clementval mentioned this in rG2c2e5a5d0f19: [flang] Basic local variable lowering.Feb 7 2022, 12:14 AM

clementval removed a parent revision: D118978: [flang] Basic local variable lowering.Feb 7 2022, 12:15 AM

Closed by commit rG6518c40931e3: [flang] Add test for quiet with local variable in STOP stmt (authored by clementval). · Explain WhyFeb 7 2022, 12:17 AM

This revision was automatically updated to reflect the committed changes.

clementval added a commit: rG6518c40931e3: [flang] Add test for quiet with local variable in STOP stmt.

Revision Contents

Path

Size

flang/

test/

Lower/

stop-statement.f90

13 lines

Diff 406340

flang/test/Lower/stop-statement.f90

	Show All 32 Lines
	subroutine stop_quiet_constant()			subroutine stop_quiet_constant()
	stop, quiet = .true.			stop, quiet = .true.
	! CHECK-DAG: %[[true:.*]] = arith.constant true			! CHECK-DAG: %[[true:.*]] = arith.constant true
	! CHECK-DAG: %[[false:.*]] = arith.constant false			! CHECK-DAG: %[[false:.*]] = arith.constant false
	! CHECK-DAG: %[[c0:.*]] = arith.constant 0 : i32			! CHECK-DAG: %[[c0:.*]] = arith.constant 0 : i32
	! CHECK: fir.call @_Fortran{{.*}}StopStatement(%[[c0]], %[[false]], %[[true]])			! CHECK: fir.call @_Fortran{{.*}}StopStatement(%[[c0]], %[[false]], %[[true]])
	! CHECK-NEXT: fir.unreachable			! CHECK-NEXT: fir.unreachable
	end subroutine			end subroutine

				! CHECK-LABEL stop_quiet
				subroutine stop_quiet()
				logical :: b
				stop, quiet = b
				! CHECK-DAG: %[[c0:.*]] = arith.constant 0 : i32
				! CHECK-DAG: %[[false:.*]] = arith.constant false
				! CHECK: %[[ALLOCA:.*]] = fir.alloca !fir.logical<4> {bindc_name = "b", uniq_name = "_QFstop_quietEb"}
				kiranchandramohanUnsubmitted Not Done Reply Inline Actions Can you check for the alloca also? kiranchandramohan: Can you check for the alloca also?
				! CHECK: %[[b:.*]] = fir.load %[[ALLOCA]]
				! CHECK: %[[bi1:.*]] = fir.convert %[[b]] : (!fir.logical<4>) -> i1
				! CHECK: fir.call @_Fortran{{.*}}StopStatement(%[[c0]], %[[false]], %[[bi1]])
				! CHECK-NEXT: fir.unreachable
				end subroutine