This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Support code object v5
ClosedPublic

Authored by yaxunl on Feb 3 2022, 2:38 PM.

Details

Summary

New device library supporting v4 and v5 has abi_version_400.bc and abi_version_500.bc.

For v5, abi_version_500.bc is linked.

For v2-4, abi_version_400.bc is linked.

For old device library, for v2-4, none of the above is linked. For v5, error is emitted about unsupported ABI version.

Diff Detail

Event Timeline

yaxunl created this revision.Feb 3 2022, 2:38 PM
yaxunl requested review of this revision.Feb 3 2022, 2:38 PM
tra accepted this revision.Feb 3 2022, 2:58 PM

Few nits, LGTM in general.

clang/lib/Driver/ToolChains/ROCm.h
27

ABIVersion?

29

CodeObjectVersion

34–39

This could use a comment on how code object version relates to the ABI version and what makes ABI version 500 special.

This revision is now accepted and ready to land.Feb 3 2022, 2:58 PM
yaxunl marked 2 inline comments as done.Feb 3 2022, 6:55 PM

Will revise as recommended when committing. Thanks.

This revision was landed with ongoing or failed builds.Feb 4 2022, 6:55 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 6:55 AM