This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][NFC] AMDGPUUsage.rst: fix wording.
ClosedPublic

Authored by lancesix on Feb 3 2022, 7:16 AM.

Download Raw Diff

Details

Reviewers

t-tye
scott.linder
arsenm

Summary

Fix fording in AMDUSAGE.rst.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60,090 ms	x64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
	60,170 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
	60,300 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
	60,150 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics-overloaded::vluxseg.c
	60,060 ms	x64 debian > MLIR.Examples/standalone::test.toy
		View Full Test Results (12 Failed)

Event Timeline

lancesix created this revision.Feb 3 2022, 7:16 AM

Herald added subscribers: kerbowa, tpr, dstuttard and 3 others. · View Herald TranscriptFeb 3 2022, 7:16 AM

lancesix requested review of this revision.Feb 3 2022, 7:16 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 7:16 AM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

LGTM but the whole sentence is still really wordy

This revision is now accepted and ready to land.Feb 3 2022, 7:23 AM

Thanks arsenm, I do not have push access. Can you push the patch for me?

Harbormaster completed remote builds in B147393: Diff 405632.Feb 3 2022, 8:29 AM

LGTM

046017291f1279d1f84b6ed21546a4bfaefc8b03

Revision Contents

Path

Size

llvm/

docs/

AMDGPUUsage.rst

6 lines

Diff 405632

llvm/docs/AMDGPUUsage.rst

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 3,611 Lines • ▼ Show 20 Lines

	To dispatch a kernel the following actions are performed. This can occur in the			To dispatch a kernel the following actions are performed. This can occur in the
	CPU host program, or from an HSA kernel executing on a GPU.			CPU host program, or from an HSA kernel executing on a GPU.

	1. A pointer to an AQL queue for the kernel agent on which the kernel is to be			1. A pointer to an AQL queue for the kernel agent on which the kernel is to be
	executed is obtained.			executed is obtained.
	2. A pointer to the kernel descriptor (see			2. A pointer to the kernel descriptor (see
	:ref:`amdgpu-amdhsa-kernel-descriptor`) of the kernel to execute is obtained.			:ref:`amdgpu-amdhsa-kernel-descriptor`) of the kernel to execute is obtained.
	It must be for a kernel that is contained in a code object that that was			It must be for a kernel that is contained in a code object that was loaded
	loaded by an HSA compatible runtime on the kernel agent with which the AQL			by an HSA compatible runtime on the kernel agent with which the AQL queue is
	queue is associated.			associated.
	3. Space is allocated for the kernel arguments using the HSA compatible runtime			3. Space is allocated for the kernel arguments using the HSA compatible runtime
	allocator for a memory region with the kernarg property for the kernel agent			allocator for a memory region with the kernarg property for the kernel agent
	that will execute the kernel. It must be at least 16-byte aligned.			that will execute the kernel. It must be at least 16-byte aligned.
	4. Kernel argument values are assigned to the kernel argument memory			4. Kernel argument values are assigned to the kernel argument memory
	allocation. The layout is defined in the *HSA Programmer's Language			allocation. The layout is defined in the *HSA Programmer's Language
	Reference* [HSA]_. For AMDGPU the kernel execution directly accesses the			Reference* [HSA]_. For AMDGPU the kernel execution directly accesses the
	kernel argument memory in the same way constant memory is accessed. (Note			kernel argument memory in the same way constant memory is accessed. (Note
	that the HSA specification allows an implementation to copy the kernel			that the HSA specification allows an implementation to copy the kernel
	▲ Show 20 Lines • Show All 8,905 Lines • Show Last 20 Lines