This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] HWRegs TMA and TBA also supported on gfx9
ClosedPublic

Authored by rampitec on Feb 2 2022, 4:17 PM.

Diff Detail

Event Timeline

rampitec created this revision.Feb 2 2022, 4:17 PM
rampitec requested review of this revision.Feb 2 2022, 4:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 4:17 PM
Herald added a subscriber: wdng. · View Herald Transcript
dp accepted this revision.Feb 3 2022, 1:27 AM

LGTM. Actually, this is a duplicate of https://reviews.llvm.org/D118123. I'm sorry that I did not add you to that review.

This revision is now accepted and ready to land.Feb 3 2022, 1:27 AM
foad added a comment.Feb 3 2022, 1:31 AM

Do we also need the update to docs/AMDGPU/gfx9_hwreg.rst from D118123?

dp added a comment.Feb 3 2022, 2:10 AM

Do we also need the update to docs/AMDGPU/gfx9_hwreg.rst from D118123?

It is optional. Usually I update documentation myself.

In D118860#3292885, @dp wrote:

LGTM. Actually, this is a duplicate of https://reviews.llvm.org/D118123. I'm sorry that I did not add you to that review.

I actually like moving ID_SYMBOLIC_FIRST_GFX10_ more than special casing register names in the validation.

In D118860#3292969, @dp wrote:

Do we also need the update to docs/AMDGPU/gfx9_hwreg.rst from D118123?

It is optional. Usually I update documentation myself.

Thanks, I will defer that to you.

This revision was landed with ongoing or failed builds.Feb 3 2022, 9:36 AM
This revision was automatically updated to reflect the committed changes.