This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] add sub register enums on x64 Windows
ClosedPublic

Authored by zequanwu on Feb 1 2022, 5:22 PM.

Details

Summary

This adds 32bit, 16bit, 8bit register enumerations to x64 Windows.

Diff Detail

Event Timeline

zequanwu requested review of this revision.Feb 1 2022, 5:22 PM
zequanwu created this revision.
labath accepted this revision.Feb 2 2022, 2:07 AM

This would be a good example of why switching to the lldb-server based implementation would be beneficial. We now have code which will automatically create these subregisters there, and so I may soon start removing these registers from other targets.

This revision is now accepted and ready to land.Feb 2 2022, 2:07 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2022, 2:21 PM

This broke the windows bot in the best way possible - by making some tests pass now that didn't use to. Could you un-xfail those too?

https://lab.llvm.org/buildbot/#/builders/83/builds/14736