[LLDB] Fix window bot failure

[zequanwu]

Summary

This attempts to fix this bot failure: https://lab.llvm.org/buildbot/#/builders/83/builds/14736 caused by D118750 by un-xfail those expected failed tests.

[stella.stamenova]

They should correspond to these files:

lldb-api :: functionalities/inferior-crashing/TestInferiorCrashing.py => test/API/functionalities/inferior-crashing/TestInferiorCrashing.py
lldb-api :: functionalities/inferior-crashing/TestInferiorCrashingStep.py => test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
lldb-api :: functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py => test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
lldb-api :: functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py => test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py

[zequanwu]

Un-xfail more tests.

[stella.stamenova]

LGTM, I think there might be a couple more places to remove the xfail, but otherwise ship it!

lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py

46

Do all the places where this bug was mentioned pass now?

[zequanwu]

lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py

46

I don't know. I failed to run lldb api tests with my current windows environment. I just removed the expected failures based on the bot output.

[stella.stamenova]

lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py

46

That makes sense. Please commit this and let's see.

[stella.stamenova]

Thanks!

It looks like there's a failure that was previously hidden by the unexpected passes:

https://lab.llvm.org/buildbot/#/builders/83/builds/14781

It seems like it's been in all of the previous builds as well, but it was not reported separately for some reason.

[zequanwu]

In D118866#3294695, @stella.stamenova wrote:

Thanks!

It looks like there's a failure that was previously hidden by the unexpected passes:

https://lab.llvm.org/buildbot/#/builders/83/builds/14781

It seems like it's been in all of the previous builds as well, but it was not reported separately for some reason.

Should be fixed by this: https://reviews.llvm.org/rGac73e12ee0ec9b6118def9150d490843047f58e0

lldb/test/API/commands/register/register/register_command/TestRegisters.py

class RegisterCommandsTestCase(TestBase):
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr37683")
     def test_convenience_registers(self):
         """Test convenience registers."""
         self.build()
         self.convenience_registers()
 
     @skipIfiOSSimulator
     @skipIf(archs=no_match(['amd64', 'x86_64']))
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr37683")
     def test_convenience_registers_with_process_attach(self):
         """Test convenience registers after a 'process attach'."""
         self.build()
         self.convenience_registers_with_process_attach(test_16bit_regs=False)
 
     @skipIfiOSSimulator
     @skipIf(archs=no_match(['amd64', 'x86_64']))
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr37683")
     def test_convenience_registers_16bit_with_process_attach(self):
         """Test convenience registers after a 'process attach'."""
         self.build()
         self.convenience_registers_with_process_attach(test_16bit_regs=True)
 
     def common_setup(self):
         exe = self.getBuildArtifact("a.out")
 

lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashing.py

class CrashingInferiorTestCase(TestBase):
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     @expectedFailureNetBSD
     def test_inferior_crashing(self):
         """Test that lldb reliably catches the inferior crashing (command)."""
         self.build()
         self.inferior_crashing()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_inferior_crashing_register(self):
         """Test that lldb reliably reads registers from the inferior after crashing (command)."""
         self.build()
         self.inferior_crashing_registers()
 
     @add_test_categories(['pyapi'])
     def test_inferior_crashing_python(self):
         """Test that lldb reliably catches the inferior crashing (Python API)."""

lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py

class CrashingInferiorStepTestCase(TestBase):
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     @expectedFailureNetBSD
     def test_inferior_crashing(self):
         """Test that lldb reliably catches the inferior crashing (command)."""
         self.build()
         self.inferior_crashing()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_inferior_crashing_register(self):
         """Test that lldb reliably reads registers from the inferior after crashing (command)."""
         self.build()
         self.inferior_crashing_registers()
 
     @add_test_categories(['pyapi'])
     def test_inferior_crashing_python(self):
         """Test that lldb reliably catches the inferior crashing (Python API)."""
         self.build()
         self.inferior_crashing_python()
 
     def test_inferior_crashing_expr(self):
         """Test that the lldb expression interpreter can read from the inferior after crashing (command)."""
         self.build()
         self.inferior_crashing_expr()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_inferior_crashing_step(self):
         """Test that stepping after a crash behaves correctly."""
         self.build()
         self.inferior_crashing_step()
 
     @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_inferior_crashing_step_after_break(self):
         """Test that lldb functions correctly after stepping through a crash."""
         self.build()
         self.inferior_crashing_step_after_break()
 
     # Inferior exits after stepping after a segfault. This is working as
     # intended IMHO.
     @skipIf(oslist=["freebsd", "linux", "netbsd"])

lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py

class CrashingRecursiveInferiorTestCase(TestBase):
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     @expectedFailureNetBSD
     def test_recursive_inferior_crashing(self):
         """Test that lldb reliably catches the inferior crashing (command)."""
         self.build()
         self.recursive_inferior_crashing()
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_register(self):
         """Test that lldb reliably reads registers from the inferior after crashing (command)."""
         self.build()
         self.recursive_inferior_crashing_registers()
 
     @add_test_categories(['pyapi'])
     def test_recursive_inferior_crashing_python(self):
         """Test that lldb reliably catches the inferior crashing (Python API)."""

lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py

 """Test that lldb steps correctly after the inferior has crashed while in a recursive routine."""
 
 
 import lldb
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbplatformutil
 from lldbsuite.test import lldbutil
 
 
 class CrashingRecursiveInferiorStepTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_recursive_inferior_crashing_step(self):
         """Test that stepping after a crash behaves correctly."""
         self.build()
         self.recursive_inferior_crashing_step()
 
     @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     @expectedFailureNetBSD