This is an archive of the discontinued LLVM Phabricator instance.

Differential D118725

[libc++] Add Unstable ABI CI run
ClosedPublic

Authored by philnik on Feb 1 2022, 12:23 PM.

Details

Reviewers
ldionne
• Quuxplusone
Mordante
Group Reviewers
Restricted Project
Commits
rG5488021f3ed9: [libc++] Add Unstable ABI CI run

Diff Detail

Event Timeline

philnik created this revision.Feb 1 2022, 12:23 PM
Herald added a subscriber: arichardson. · View Herald TranscriptFeb 1 2022, 12:23 PM
philnik requested review of this revision.Feb 1 2022, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2022, 12:23 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B146987: Diff 405051.Feb 1 2022, 2:50 PM
Mordante accepted this revision as: Mordante.Feb 2 2022, 9:10 AM
Mordante added a subscriber: Mordante.

LGTM after using the proper config.

libcxx/utils/ci/run-buildbot
395

This should use the default config. (Also properly format after the change.)

philnik updated this revision to Diff 405383.Feb 2 2022, 12:10 PM
philnik marked an inline comment as done.
  • Use default config
Harbormaster completed remote builds in B147222: Diff 405383.Feb 2 2022, 3:29 PM
ldionne added inline comments.Feb 4 2022, 2:02 PM
libcxx/utils/ci/run-buildbot
397

Can you please create a CMake cache file like we do for the other jobs?

philnik updated this revision to Diff 406103.Feb 4 2022, 2:07 PM
philnik marked an inline comment as done.
  • Add cmake cache file
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 4 2022, 2:07 PM
ldionne accepted this revision.Feb 4 2022, 2:09 PM

LGTM if CI is happy!

This revision is now accepted and ready to land.Feb 4 2022, 2:09 PM
Harbormaster completed remote builds in B147716: Diff 406103.Feb 4 2022, 4:12 PM
philnik updated this revision to Diff 406168.Feb 5 2022, 3:00 AM
  • Fix CI
Harbormaster completed remote builds in B147761: Diff 406168.Feb 5 2022, 3:57 AM
philnik updated this revision to Diff 406175.Feb 5 2022, 5:00 AM

Rebased

Harbormaster completed remote builds in B147765: Diff 406175.Feb 5 2022, 5:05 AM
philnik updated this revision to Diff 406176.Feb 5 2022, 5:11 AM
  • Fix CI
Harbormaster completed remote builds in B147766: Diff 406176.Feb 5 2022, 6:08 AM
Closed by commit rG5488021f3ed9: [libc++] Add Unstable ABI CI run (authored by philnik). · Explain WhyFeb 5 2022, 6:39 AM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG5488021f3ed9: [libc++] Add Unstable ABI CI run.

Revision Contents

PathSize
libcxx/
cmake/
caches/
1 line
utils/
ci/
13 lines
7 lines

Diff 406103

libcxx/cmake/caches/Generic-abi-unstable.cmake

  • This file was added.
set(LIBCXX_ABI_UNSTABLE ON CACHE BOOL "")

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 460 Lines • ▼ Show 20 Lines agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
- label: "Unstable ABI"
command: "libcxx/utils/ci/run-buildbot generic-abi-unstable"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
# Other non-testing CI jobs # Other non-testing CI jobs
- label: "Benchmarks" - label: "Benchmarks"
command: "libcxx/utils/ci/run-buildbot benchmarks" command: "libcxx/utils/ci/run-buildbot benchmarks"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 384 Lines • ▼ Show 20 Lines
;; ;;
generic-no-wide-characters) generic-no-wide-characters)
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-no-wide-characters.cmake" \ generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-no-wide-characters.cmake" \
-DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \ -DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \
-DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in" -DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in"
check-runtimes check-runtimes
;; ;;
generic-abi-unstable)
clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-abi-unstable.cmake" \
MordanteUnsubmitted
Done
ReplyInline Actions
clean
- generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-no-wide-characters.cmake" \
+ generate-cmake \
-DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \

This should use the default config. (Also properly format after the change.)

Mordante: This should use the default config. (Also properly format after the change.)
-DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \
-DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in" \
ldionneUnsubmitted
Done
ReplyInline Actions

Can you please create a CMake cache file like we do for the other jobs?

ldionne: Can you please create a CMake cache file like we do for the other jobs?
check-runtimes
;;
apple-system) apple-system)
clean clean
sdk_root="$(xcrun --sdk macosx --show-sdk-path)" sdk_root="$(xcrun --sdk macosx --show-sdk-path)"
arch="$(uname -m)" arch="$(uname -m)"
${MONOREPO_ROOT}/libcxx/utils/ci/apple-install-libcxx.sh \ ${MONOREPO_ROOT}/libcxx/utils/ci/apple-install-libcxx.sh \
--llvm-root ${MONOREPO_ROOT} \ --llvm-root ${MONOREPO_ROOT} \
▲ Show 20 Lines • Show All 263 Lines • Show Last 20 Lines