[HWASan] Properly handle musttail calls.

[morehouse]

Summary

Fixes a compile error when the clang::musttail attribute is used.

[eugenis]

LGTM

@fmayer FYI we will need the same in AArch64StackTagging.

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

1539

isa<ResumeInst, CleanupReturnInst>

[morehouse]

• Use a single isa<Type0, Type1>.

[fmayer]

In D118712#3288114, @eugenis wrote:

LGTM

@fmayer FYI we will need the same in AArch64StackTagging.

Aarch64StackTagging fix in D118854.

compiler-rt/test/hwasan/TestCases/musttail.cpp

+// RUN: %clangxx_hwasan -mllvm -hwasan-use-stack-safety=0 %s -o %t
+// RUN: %run %t
+//
+// REQUIRES: pointer-tagging
+
+__attribute__((noinline)) int bar(int X) { return X; }
+
+__attribute__((noinline)) int foo(int X) {
+  volatile int A = 5;
+  [[clang::musttail]] return bar(X + A);
+}
+
+int main(int Argc, char *Argv[]) { return foo(Argc) != 6; }

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp

for (auto &Inst : BB) {
           if (II->getIntrinsicID() == Intrinsic::lifetime_start)
             AllocasToInstrument[AI].LifetimeStart.push_back(II);
           else
             AllocasToInstrument[AI].LifetimeEnd.push_back(II);
           continue;
         }
       }
 
-      if (isa<ReturnInst>(Inst) || isa<ResumeInst>(Inst) ||
-          isa<CleanupReturnInst>(Inst))
+      if (isa<ReturnInst>(Inst)) {
+        if (CallInst *CI = Inst.getParent()->getTerminatingMustTailCall())
+          RetVec.push_back(CI);
+        else
+          RetVec.push_back(&Inst);
+      } else if (isa<ResumeInst, CleanupReturnInst>(Inst)) {
         RetVec.push_back(&Inst);
+      }
 
       if (auto *DVI = dyn_cast<DbgVariableIntrinsic>(&Inst)) {
         for (Value *V : DVI->location_ops()) {
           if (auto *Alloca = dyn_cast_or_null<AllocaInst>(V))
             if (!AllocaDbgMap.count(Alloca) ||
                 AllocaDbgMap[Alloca].back() != DVI)
               AllocaDbgMap[Alloca].push_back(DVI);
         }