[MSVC] Workaround missing search path for sanitizer headers.

[pgousseau]

Summary

This is to fix build errors “Cannot open include file: 'sanitizer/asan_interface.h'” when building LLVM with MSVC and LLVM_USE_SANITIZER=Address.

asan_interface.h is not available in MSVC's search path, instead it is located under %VCToolsInstallDir%/crt/src/sanitizer

This is an alternate solution to https://reviews.llvm.org/D118159 , to avoid adding all internal crt sources to the header search paths.

Tested with visual studio 2019 v16.9.6

[aaron.ballman]

llvm/include/llvm/Support/Compiler.h

451–453

I think this should be hoisted up closer to line 40 after the __has_builtin definition.

[pgousseau]

Hoist up __has_include ifdef guard as per comment.

[pgousseau]

llvm/include/llvm/Support/Compiler.h

451–453

Thank you! Yes makes sense. Patch updated.

[rnk]

llvm/include/llvm/Support/Compiler.h

453–465

Please add a comment in this #else block that these declarations exist to support ASan with MSVC. If MSVC eventually ships asan_interface.h in their headers, we can remove this.

[pgousseau]

Add comment as suggested.

[rnk]

lgtm

llvm/include/llvm/Support/Compiler.h

 #ifndef __has_attribute
 # define __has_attribute(x) 0
 #endif
 
 #ifndef __has_builtin
 # define __has_builtin(x) 0
 #endif
 
+#ifndef __has_include
+# define __has_include(x) 0
+#endif
+
 // Only use __has_cpp_attribute in C++ mode. GCC defines __has_cpp_attribute in
 // C mode, but the :: in __has_cpp_attribute(scoped::attribute) is invalid.
 #ifndef LLVM_HAS_CPP_ATTRIBUTE
 #if defined(__cplusplus) && defined(__has_cpp_attribute)
 # define LLVM_HAS_CPP_ATTRIBUTE(x) __has_cpp_attribute(x)
 #else
 # define LLVM_HAS_CPP_ATTRIBUTE(x) 0
 #endif

 # define __msan_unpoison(p, size)
 # define LLVM_NO_SANITIZE_MEMORY_ATTRIBUTE
 #endif
 
 /// \macro LLVM_ADDRESS_SANITIZER_BUILD
 /// Whether LLVM itself is built with AddressSanitizer instrumentation.
 #if __has_feature(address_sanitizer) || defined(__SANITIZE_ADDRESS__)
 # define LLVM_ADDRESS_SANITIZER_BUILD 1
+#if __has_include(<sanitizer/asan_interface.h>)
 # include <sanitizer/asan_interface.h>
 #else
+// These declarations exist to support ASan with MSVC. If MSVC eventually ships
+// asan_interface.h in their headers, then we can remove this.
+#ifdef __cplusplus
+extern "C" {
+#endif
+void __asan_poison_memory_region(void const volatile *addr, size_t size);
+void __asan_unpoison_memory_region(void const volatile *addr, size_t size);
+#ifdef __cplusplus
+} // extern "C"
+#endif
+#endif
+#else
 # define LLVM_ADDRESS_SANITIZER_BUILD 0
 # define __asan_poison_memory_region(p, size)
 # define __asan_unpoison_memory_region(p, size)
 #endif
 
 /// \macro LLVM_THREAD_SANITIZER_BUILD
 /// Whether LLVM itself is built with ThreadSanitizer instrumentation.
 #if __has_feature(thread_sanitizer) || defined(__SANITIZE_THREAD__)