This is an archive of the discontinued LLVM Phabricator instance.

Differential D118474

[NFC][AIX][clang] un-XFAIL gcc profile flag compat test
ClosedPublic

Authored by daltenty on Jan 28 2022, 7:48 AM.

Download Raw Diff

Details

Reviewers

sfertile
stevewan
Whitney

Commits

rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

Summary

We can pass this test now thanks to recent changes that allow us to use PGO without LTO, so un-XFAIL the test and update the comments.

Diff Detail

Event Timeline

daltenty created this revision.Jan 28 2022, 7:48 AM

Herald added a subscriber: wenlei. · View Herald TranscriptJan 28 2022, 7:48 AM

daltenty requested review of this revision.Jan 28 2022, 7:48 AM

Extra coverage for LTO doesn't hurt. LGTM. Thanks.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2022, 8:19 AM

This revision was landed with ongoing or failed builds.

Closed by commit rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test (authored by daltenty). · Explain Why

This revision was automatically updated to reflect the committed changes.

daltenty added a commit: rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test.

Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 8:19 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B146290: Diff 404023.Jan 28 2022, 8:42 AM

Thanks David.

Revision Contents

Path

Size

clang/

test/

Profile/

gcc-flag-compatibility-aix.c

3 lines

gcc-flag-compatibility.c

3 lines

Diff 404023

clang/test/Profile/gcc-flag-compatibility-aix.c

Context not available.
	// -fprofile-use=<dir> Uses the profile file <dir>/default.profdata			// -fprofile-use=<dir> Uses the profile file <dir>/default.profdata
	// -fprofile-use=<dir>/file Uses the profile file <dir>/file			// -fprofile-use=<dir>/file Uses the profile file <dir>/file

	// On AIX, -flto is required with -fprofile-generate			// On AIX, -flto used to be required with -fprofile-generate, so test those
				// extra cases.

	// RUN: %clang %s -c -S -o - -emit-llvm -target powerpc64-unknown-aix -flto -fprofile-generate \| FileCheck -check-prefix=PROFILE-GEN %s			// RUN: %clang %s -c -S -o - -emit-llvm -target powerpc64-unknown-aix -flto -fprofile-generate \| FileCheck -check-prefix=PROFILE-GEN %s
	// PROFILE-GEN: @__profc_main = {{(private\|internal)}} global [2 x i64] zeroinitializer, section			// PROFILE-GEN: @__profc_main = {{(private\|internal)}} global [2 x i64] zeroinitializer, section
Context not available.

clang/test/Profile/gcc-flag-compatibility.c

Context not available.
	// -fprofile-use=<dir> Uses the profile file <dir>/default.profdata			// -fprofile-use=<dir> Uses the profile file <dir>/default.profdata
	// -fprofile-use=<dir>/file Uses the profile file <dir>/file			// -fprofile-use=<dir>/file Uses the profile file <dir>/file

	// On AIX, -flto is required with -fprofile-generate. gcc-flag-compatibility-aix.c is used to do the testing on AIX with -flto			// On AIX, -flto used to be required with -fprofile-generate. gcc-flag-compatibility-aix.c is used to do the testing on AIX with -flto
	// XFAIL: aix
	// RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate \| FileCheck -check-prefix=PROFILE-GEN %s			// RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate \| FileCheck -check-prefix=PROFILE-GEN %s
	// PROFILE-GEN: @__profc_main = {{(private\|internal)}} global [2 x i64] zeroinitializer, section			// PROFILE-GEN: @__profc_main = {{(private\|internal)}} global [2 x i64] zeroinitializer, section
	// PROFILE-GEN: @__profd_main =			// PROFILE-GEN: @__profd_main =
Context not available.