Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Notes for reviewers:
- mlir/test/Dialect/Linalg/transform-patterns-matmul-to-vector.mlir was removed, since it has fusion on memrefs.
- Vectorization.cpp now contains a pattern to vectorize CopyOp in absence of LinalgOp interface.
Comment Actions
Thanks @pifon2a, this was long overdue!
Please note the recent https://reviews.llvm.org/D117696 and that the situation is not 100% rosy as I have measure the memref.copy -> library call to be around 200x slower than a properly tiled and vectorized linalg.copy.
At this point memref.copy cannot tile and would significantly degrade perf in certain cases.
Let's iterate a bit on benchmarks before we land this if you don't mind.
Still this is a great step forward !
Comment Actions
Thanks yes,
I made a similar transition in the sparse compiler part a while back (because my understanding was that memref.copy would get all the attention over linalg.copy).
I hope we can migrate the performance into the new op soon!