This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Fail inlayHints requests on content changes
ClosedPublic

Authored by kadircet on Jan 20 2022, 5:11 AM.

Details

Summary

This should improve the overall UX by making the labels less jumpy.

Diff Detail

Event Timeline

kadircet created this revision.Jan 20 2022, 5:11 AM
kadircet requested review of this revision.Jan 20 2022, 5:11 AM
sammccall accepted this revision.Jan 20 2022, 8:35 AM

This seems right for consistency with SemanticHighlights.

However I don't think it will much improve the jumpiness you refer to - there's no time-based debounce here, so it only helps if you manage to bring the code from valid->invalid->valid without ever letting a request complete...

This revision is now accepted and ready to land.Jan 20 2022, 8:35 AM
This revision was automatically updated to reflect the committed changes.