Remove the last remaining references to the reproducers from the instrumentation.
- ReproducerInstrumentation.cpp -> Instrumentation.cpp
- LLDB_RECORD_ -> LLDB_INSTRUMENT
I was going to with a more SBAPI/LLDB API focussed naming scheme, but D117632 made me decide to keep things more generic.
I didn't notice this before, but I think this should really be in some namespace, ideally even separated from the rest of "normal" code. lldb_private::instrumentation perhaps?