This is an archive of the discontinued LLVM Phabricator instance.

[llvm][AArch64] Accept armv8.8 "hbc" and "mops" in .arch_extension directive
ClosedPublic

Authored by DavidSpickett on Jan 19 2022, 8:59 AM.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jan 19 2022, 8:59 AM
DavidSpickett requested review of this revision.Jan 19 2022, 8:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2022, 8:59 AM

This isn't an exhaustive cross check of the list here and the target parser, just checked the latest few. sme has its own test file for this.

Did not add pmuv3 because as I understand it, removing that feature does not remove the PMU related register from the assembler. It only effects codegen that would use it.

This is looking good. Do we also need a test in llvm/test/MC/AArch64/directive-arch_extension-negative.s too?

Add negative tests in directive-arch_extension-negative.s.

lenary accepted this revision.Jan 19 2022, 9:43 AM
This revision is now accepted and ready to land.Jan 19 2022, 9:43 AM