This is an archive of the discontinued LLVM Phabricator instance.

Differential D117659

[mlir] Annotate methods on a correct class in PybindAdaptors.h
ClosedPublic

Authored by ftynse on Jan 19 2022, 4:45 AM.

Details

Reviewers
stellaraccident
gysit
Commits
rG8b734798a55b: [mlir] Annotate methods on a correct class in PybindAdaptors.h
Summary

The .def and .def_property_readonly functions in PybindAdaptors.h should
construct the functions as method of the current class rather than as method of
pybind11:none(), which is an object and not even a class.

Depends On D117658

Diff Detail

Event Timeline

ftynse created this revision.Jan 19 2022, 4:45 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptJan 19 2022, 4:45 AM
ftynse requested review of this revision.Jan 19 2022, 4:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2022, 4:45 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B144249: Diff 401174.Jan 19 2022, 5:07 AM
ftynse added a reviewer: gysit.Feb 21 2022, 3:56 AM
gysit accepted this revision.Feb 21 2022, 4:03 AM
This revision is now accepted and ready to land.Feb 21 2022, 4:03 AM
This revision was landed with ongoing or failed builds.Feb 21 2022, 4:04 AM
Closed by commit rG8b734798a55b: [mlir] Annotate methods on a correct class in PybindAdaptors.h (authored by ftynse). · Explain Why
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG8b734798a55b: [mlir] Annotate methods on a correct class in PybindAdaptors.h.

Revision Contents

PathSize
mlir/
include/
mlir/
Bindings/
Python/
4 lines

Diff 401174

mlir/include/mlir/Bindings/Python/PybindAdaptors.h

Show First 20 Lines • Show All 243 Lines • ▼ Show 20 Lines pure_subclass(py::handle scope, const char *derivedClassName,
thisClass = thisClass =
metaclass(derivedClassName, py::make_tuple(superClass), attributes); metaclass(derivedClassName, py::make_tuple(superClass), attributes);
scope.attr(derivedClassName) = thisClass; scope.attr(derivedClassName) = thisClass;
} }
template <typename Func, typename... Extra> template <typename Func, typename... Extra>
pure_subclass &def(const char *name, Func &&f, const Extra &... extra) { pure_subclass &def(const char *name, Func &&f, const Extra &... extra) {
py::cpp_function cf( py::cpp_function cf(
std::forward<Func>(f), py::name(name), py::is_method(py::none()), std::forward<Func>(f), py::name(name), py::is_method(thisClass),
py::sibling(py::getattr(thisClass, name, py::none())), extra...); py::sibling(py::getattr(thisClass, name, py::none())), extra...);
thisClass.attr(cf.name()) = cf; thisClass.attr(cf.name()) = cf;
return *this; return *this;
} }
template <typename Func, typename... Extra> template <typename Func, typename... Extra>
pure_subclass &def_property_readonly(const char *name, Func &&f, pure_subclass &def_property_readonly(const char *name, Func &&f,
const Extra &... extra) { const Extra &... extra) {
py::cpp_function cf( py::cpp_function cf(
std::forward<Func>(f), py::name(name), py::is_method(py::none()), std::forward<Func>(f), py::name(name), py::is_method(thisClass),
py::sibling(py::getattr(thisClass, name, py::none())), extra...); py::sibling(py::getattr(thisClass, name, py::none())), extra...);
auto builtinProperty = auto builtinProperty =
py::reinterpret_borrow<py::object>((PyObject *)&PyProperty_Type); py::reinterpret_borrow<py::object>((PyObject *)&PyProperty_Type);
thisClass.attr(name) = builtinProperty(cf); thisClass.attr(name) = builtinProperty(cf);
return *this; return *this;
} }
template <typename Func, typename... Extra> template <typename Func, typename... Extra>
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines