Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D117540

[mlir][cmake] Use `GNUInstallDirs` to support custom installation dirs
ClosedPublic
Actions

Authored by Ericson2314 on Jan 17 2022, 11:04 PM.

Details

Reviewers
compnerd
phosek
beanz
Commits
rG5ad96992ef90: [mlir][cmake] Use `GNUInstallDirs` to support custom installation dirs
Summary

I am breaking apart D99484 so the cause of build failures is easier to
understand.

Diff Detail

Event Timeline

Ericson2314 created this revision.Jan 17 2022, 11:04 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptJan 17 2022, 11:04 PM
Ericson2314 requested review of this revision.Jan 17 2022, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 11:04 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B143940: Diff 400731.Jan 17 2022, 11:28 PM
Ericson2314 updated this revision to Diff 400997.Jan 18 2022, 2:43 PM

rebase to see how CI is affected

Ericson2314 updated this revision to Diff 400998.Jan 18 2022, 2:44 PM

Fix bug

Harbormaster completed remote builds in B144126: Diff 400998.Jan 18 2022, 4:55 PM
Ericson2314 added a comment.EditedJan 19 2022, 9:09 AM

Most this code was already approved in D99484, and the one newer bit is an exact clone of the parts in approved and merged D117541 (for polly), so I am going to merge this to continue my bisecting saga.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2022, 9:11 AM
Closed by commit rG5ad96992ef90: [mlir][cmake] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). · Explain Why
This revision was automatically updated to reflect the committed changes.
Ericson2314 added a commit: rG5ad96992ef90: [mlir][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Revision Contents
Changeset List

PathSize
mlir/
6 lines
cmake/
modules/
3 lines
4 lines

Diff 401278

View Options

mlir/CMakeLists.txt

Loading...
View Options

mlir/cmake/modules/AddMLIR.cmake

Loading...
View Options

mlir/cmake/modules/CMakeLists.txt

Loading...