[clangd] NFC, emit source ranges in selection debug messages.

[hokein]

Summary

It will make the output more versbose, but I found that these are useful
information when debugging selection tree.

[sammccall]

clang-tools-extra/clangd/Selection.cpp

550–551

I don't think this belongs in printNodeToString but rather explicitly in the log statements that call it.

780–781

We're already printing the range here, which only differs rarely. This seems noisy and confusing.
(S is a better range to print than N.getSourceRange here - no objection if you want to change the log formatting to print it similarly to the others)

814

are we sure we want to print the range again on pop? Seems like on enter/skip is sufficient. It's useful to be able to visually distinguish push vs pop.

[hokein]

address commment, only printing range on push.

clang-tools-extra/clangd/Selection.cpp

780–781

I inlined these two into one dlog, which makes the output more dense.

814

oh, right, we don't need that. I think printing range on push is sufficient.

[sammccall]

Thanks!

clang-tools-extra/clangd/Selection.cpp

550–551

hmm, while here, this extra space seems weird.

Previously it was at EOL and invisible.

After this patch it's used, but I think it'd be clearer to move it to the format string.

clang-tools-extra/clangd/Selection.cpp

if (const TypeLoc *TL = N.get<TypeLoc>()) {
     OS << N.getNodeKind().asStringRef();
   }
 }
 
 #ifndef NDEBUG
 std::string printNodeToString(const DynTypedNode &N, const PrintingPolicy &PP) {
   std::string S;
   llvm::raw_string_ostream OS(S);
   printNodeKind(OS, N);
-  OS << " ";
   return std::move(OS.str());
 }
 #endif
 
 bool isImplicit(const Stmt *S) {
   // Some Stmts are implicit and shouldn't be traversed, but there's no
   // "implicit" attribute on Stmt/Expr.
   // Unwrap implicit casts first if present (other nodes too?).
   if (auto *ICE = llvm::dyn_cast<ImplicitCastExpr>(S))
if (auto *TL = N.get<TypeLoc>()) {
         S = AT.getModifiedLoc().getSourceRange();
     }
     // SourceRange often doesn't manage to accurately cover attributes.
     // Fortunately, attributes are rare.
     if (llvm::any_of(getAttributes(N),
                      [](const Attr *A) { return !A->isImplicit(); }))
       return false;
     if (!SelChecker.mayHit(S)) {
-      dlog("{1}skip: {0}", printNodeToString(N, PrintPolicy), indent());
-      dlog("{1}skipped range = {0}", S.printToString(SM), indent(1));
+      dlog("{2}skip: {0} {1}", printNodeToString(N, PrintPolicy),
+           S.printToString(SM), indent());
       return true;
     }
     return false;
   }
 
   // There are certain nodes we want to treat as leaves in the SelectionTree,
   // although they do have children.
   bool shouldSkipChildren(const Stmt *X) const {
     // UserDefinedLiteral (e.g. 12_i) has two children (12 and _i).
     // Unfortunately TokenBuffer sees 12_i as one token and can't split it.
     // So we treat UserDefinedLiteral as a leaf node, owning the token.
     return llvm::isa<UserDefinedLiteral>(X);
   }
 
   // Pushes a node onto the ancestor stack. Pairs with pop().
   // Performs early hit detection for some nodes (on the earlySourceRange).
   void push(DynTypedNode Node) {
     SourceRange Early = earlySourceRange(Node);
-    dlog("{1}push: {0}", printNodeToString(Node, PrintPolicy), indent());
+    dlog("{2}push: {0} {1}", printNodeToString(Node, PrintPolicy),
+         Node.getSourceRange().printToString(SM), indent());
     Nodes.emplace_back();
     Nodes.back().ASTNode = std::move(Node);
     Nodes.back().Parent = Stack.top();
     Nodes.back().Selected = NoTokens;
     Stack.push(&Nodes.back());
     claimRange(Early, Nodes.back().Selected);
   }
 
   // Pops a node off the ancestor stack, and finalizes it. Pairs with push().
   // Performs primary hit detection.
   void pop() {
     Node &N = *Stack.top();
     dlog("{1}pop: {0}", printNodeToString(N.ASTNode, PrintPolicy), indent(-1));
     claimTokensFor(N.ASTNode, N.Selected);
     if (N.Selected == NoTokens)
       N.Selected = SelectionTree::Unselected;
     if (N.Selected || !N.Children.empty()) {
       // Attach to the tree.
       N.Parent->Children.push_back(&N);
     } else {
       // Neither N any children are selected, it doesn't belong in the tree.