Page MenuHomePhabricator

[PowerPC] Fix issue with strict float to int conversion.
ClosedPublic

Authored by stefanp on Jan 17 2022, 3:49 AM.

Details

Summary

When doing the float to int conversion the strict conversion also needs to
retun a chain. This patch fixes that.

Diff Detail

Event Timeline

stefanp created this revision.Jan 17 2022, 3:49 AM
stefanp requested review of this revision.Jan 17 2022, 3:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 3:49 AM
stefanp added a reviewer: Restricted Project.Jan 17 2022, 3:50 AM
stefanp updated this revision to Diff 400490.Jan 17 2022, 4:11 AM

Trimmed down some of the function attributes that were not required for the test.

qiucf accepted this revision as: qiucf.Jan 17 2022, 4:26 AM
qiucf added a subscriber: qiucf.

Thanks for the fix. Looks like there're also other places needing such fix.

This revision is now accepted and ready to land.Jan 17 2022, 4:26 AM
nemanjai added inline comments.Jan 17 2022, 6:02 AM
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
11188–11189

This would be simpler represented as N->isStrictFPOpcode().

stefanp updated this revision to Diff 400570.Jan 17 2022, 9:05 AM

Changed the if statement to use isStrictFPOpcode().

nemanjai accepted this revision.Jan 19 2022, 5:24 AM

LGTM.

This revision was landed with ongoing or failed builds.Jan 19 2022, 8:57 AM
This revision was automatically updated to reflect the committed changes.