This is an archive of the discontinued LLVM Phabricator instance.

Differential D117440

[BOLT][TEST] Update exceptions-instrumentation.test
ClosedPublic

Authored by Amir on Jan 16 2022, 1:32 PM.

Details

Reviewers
maksfb
rafauler
Commits
rG90ada97f365f: [BOLT][TEST] Update exceptions-instrumentation.test
Summary

Matching an exact byte offset is fragile if a different version of compiler
is used (e.g. distro clang).
Resolves an issue with running with BOLT_CLANG_EXE + clang-12

Diff Detail

Unit TestsFailed

TimeTest
970 msx64 debian > SanitizerCommon-asan-x86_64-Linux.Linux::decorate_proc_maps.cpp
660 msx64 debian > SanitizerCommon-lsan-x86_64-Linux.Linux::decorate_proc_maps.cpp
620 msx64 debian > SanitizerCommon-msan-x86_64-Linux.Linux::decorate_proc_maps.cpp
710 msx64 debian > SanitizerCommon-tsan-x86_64-Linux.Linux::decorate_proc_maps.cpp

Event Timeline

Amir created this revision.Jan 16 2022, 1:32 PM
Herald added a subscriber: ayermolo. · View Herald TranscriptJan 16 2022, 1:32 PM
Amir requested review of this revision.Jan 16 2022, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2022, 1:32 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Harbormaster completed remote builds in B143695: Diff 400403.Jan 16 2022, 2:35 PM
maksfb accepted this revision.Jan 18 2022, 10:51 AM

LGTM

This revision is now accepted and ready to land.Jan 18 2022, 10:51 AM
This revision was landed with ongoing or failed builds.Jan 18 2022, 11:18 AM
Closed by commit rG90ada97f365f: [BOLT][TEST] Update exceptions-instrumentation.test (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG90ada97f365f: [BOLT][TEST] Update exceptions-instrumentation.test.

Revision Contents

PathSize
bolt/
test/
runtime/
X86/
2 lines

Diff 400403

bolt/test/runtime/X86/exceptions-instrumentation.test

Show All 12 Lines
EXCEPTIONS-NOT: invalid (possibly stale) profile EXCEPTIONS-NOT: invalid (possibly stale) profile
# Check that cold symbols are emitted with local binding. # Check that cold symbols are emitted with local binding.
RUN: llvm-readelf -Ws %t.exc.bolted | FileCheck %s --check-prefix=CHECK-READELF RUN: llvm-readelf -Ws %t.exc.bolted | FileCheck %s --check-prefix=CHECK-READELF
CHECK-READELF: FUNC LOCAL DEFAULT {{.*}} main.cold.{{.*}} CHECK-READELF: FUNC LOCAL DEFAULT {{.*}} main.cold.{{.*}}
RUN: cat %t.fdata | FileCheck --check-prefix=EXCEPTIONS-FDATA %s RUN: cat %t.fdata | FileCheck --check-prefix=EXCEPTIONS-FDATA %s
# Check that the printf "catch" ran exactly 10 times # Check that the printf "catch" ran exactly 10 times
EXCEPTIONS-FDATA: 1 main 90 1 _Znwm@PLT 0 0 10 EXCEPTIONS-FDATA: 1 main {{.*}} 1 _Znwm@PLT 0 0 10