Page MenuHomePhabricator

MemoryBuiltins: simplify isLibFreeFunction
AcceptedPublic

Authored by durin42 on Fri, Jan 14, 11:45 AM.

Details

Reviewers
reames
jdoerfert
Summary

This is in anticipation of my next patch, where I need to store more
information about free functions than just their argument count. It felt
invasive enough on this function that it seemed worthwhile to just
extract this as its own commit that makes no functional changes.

Diff Detail

Event Timeline

durin42 created this revision.Fri, Jan 14, 11:45 AM
durin42 requested review of this revision.Fri, Jan 14, 11:45 AM
Herald added a project: Restricted Project. · View Herald Transcript

(My next patch isn't actually done yet, but I figured I'd get this out for review early since it doesn't seem harmful on its own and I felt like was a nice cleanup of the function.)

reames accepted this revision.Fri, Jan 14, 12:07 PM

LGTM, seems reasonable.

This revision is now accepted and ready to land.Fri, Jan 14, 12:07 PM
eopXD added a subscriber: eopXD.Fri, Jan 14, 12:21 PM

Nit: Adjust commit topic with [NFC] tag.

durin42 retitled this revision from MemoryBuiltins: simplify isLibFreeFunction to [NFC] MemoryBuiltins: simplify isLibFreeFunction.Fri, Jan 14, 12:26 PM

Done. I don't have commit access, so if someone can push this I'd appreciate it. :)

durin42 updated this revision to Diff 400121.Fri, Jan 14, 1:03 PM

Reformatted table in anticipation of my next patch, which will embiggen the table enough that clang-format makes a mess of it.

nikic added a subscriber: nikic.Fri, Jan 14, 1:04 PM
nikic added inline comments.
llvm/lib/Analysis/MemoryBuiltins.cpp
440

on?

durin42 updated this revision to Diff 400124.Fri, Jan 14, 1:05 PM

Fixed typo s/off/on/ in a clang-format directive. Sigh.

durin42 marked an inline comment as done.Fri, Jan 14, 1:05 PM
durin42 added inline comments.
llvm/lib/Analysis/MemoryBuiltins.cpp
440

Yep, I spotted that right after I hit submit. 🤦

durin42 updated this revision to Diff 401029.Tue, Jan 18, 4:11 PM
durin42 retitled this revision from [NFC] MemoryBuiltins: simplify isLibFreeFunction to MemoryBuiltins: simplify isLibFreeFunction.
durin42 edited the summary of this revision. (Show Details)
durin42 marked an inline comment as done.