Add TACO tests to test/Integration/Dialect/SparseTensor/taco. Add the MLIR
PyTACO implementation as tools under the directory.
Details
- Reviewers
aartbik mehdi_amini - Commits
- rGb7fd91c84b4e: Upstream MLIR PyTACO implementation.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
---|---|---|
150 | Could this be implemented as a registered C++ pipeline instead of listing all the passes here? |
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
---|---|---|
150 | Yeah, agreed, this is very related to https://github.com/llvm/llvm-project/issues/51751 where we express the need to avoid proliferating these veyr specific passes all over the place. |
mlir/test/Integration/Dialect/SparseTensor/taco/MTTKRP_test.py | ||
---|---|---|
12 | can you make this a line break comment, as in This PyTACO part is taken from the TACO open-source project.and then close it at line 41 with just so that the part that we used from TACO jumps more out | |
17 | maybe spell out "formats" | |
mlir/test/Integration/Dialect/SparseTensor/taco/SpMV_test.py | ||
12 | same request | |
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
4 | empty line after copyright header | |
80 | np.float16 | |
150 | Bixia, for now, I would suggest to add a TODO and link to bug |
mlir/test/Integration/Dialect/SparseTensor/taco/MTTKRP_test.py | ||
---|---|---|
12 | Ah, now I see what went wrong last time, my suggestion is being formatted by phacricator. #### This PyTACO part is taken from the TACO open-source project. #### and then end it as ####################################### |
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
---|---|---|
150 | This seems like a trivial thing to do isn't it? It probably won't take much longer that the TODO and filing the bug :) |
Address review comments.
Rename test files so that module names start with lower cases to confirm to python style guide.
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
---|---|---|
150 | Replaced this with a TODO as the ticket already has a owner and I can't just take over it. |
mlir/test/Integration/Dialect/SparseTensor/taco/tools/mlir_pytaco.py | ||
---|---|---|
150 | Alright, LG, thanks :) |
can you make this a line break comment, as in
This PyTACO part is taken from the TACO open-source project.
and then close it at line 41 with
just so that the part that we used from TACO jumps more out