This is an archive of the discontinued LLVM Phabricator instance.

[openmp][devicertl] Handle missing clang_tool

Authored by JonChesterfield on Jan 13 2022, 8:21 AM.


Diff Detail

Event Timeline

JonChesterfield requested review of this revision.Jan 13 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 8:21 AM

Spent quite a while trying to get the quoted string to break across two lines without success.

This revision is now accepted and ready to land.Jan 13 2022, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Thanks a lot for the patch! I'm trying to figure out how to apply this to 13.0.0-rc2, but it's not obvious since has happened in between and reshuffled a bunch of things around.

We could apply it to the amdgcn file and not the DeviceRTL one - the latter was off by default in 13.x so is less likely to break builds, and the older logic is fine on the happy path.

I don't know the post-bugzilla process for cherry-picking to 13.x, maybe it can be done by GitHub PR these days

OK, just taking the second half of the patch in openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt is actually enough for the backport.

Ah, just saw your comment to that exact effect in the meantime. :)