This is an archive of the discontinued LLVM Phabricator instance.

Differential D117175

[mlir][tosa] Update default tosa-to-linalg passes
ClosedPublic

Authored by rsuderman on Jan 12 2022, 5:25 PM.

Details

Reviewers
sjarus
NatashaKnk
Commits
rG173fce42052d: [mlir][tosa] Update default tosa-to-linalg passes
Summary

Adding the optional decompositions have been verified to improve memory
usage on common models. Added the decomposition to the default tosa to linalg
passes.

Diff Detail

Event Timeline

rsuderman created this revision.Jan 12 2022, 5:25 PM
Herald added a reviewer: sjarus. · View Herald TranscriptJan 12 2022, 5:25 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 24 others. · View Herald Transcript
rsuderman requested review of this revision.Jan 12 2022, 5:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 5:25 PM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rsuderman added a reviewer: NatashaKnk.Jan 12 2022, 5:26 PM
Harbormaster completed remote builds in B143052: Diff 399518.Jan 12 2022, 5:41 PM
NatashaKnk accepted this revision.Jan 12 2022, 6:37 PM
This revision is now accepted and ready to land.Jan 12 2022, 6:37 PM
Closed by commit rG173fce42052d: [mlir][tosa] Update default tosa-to-linalg passes (authored by rsuderman). · Explain WhyJan 13 2022, 10:19 AM
This revision was automatically updated to reflect the committed changes.
rsuderman added a commit: rG173fce42052d: [mlir][tosa] Update default tosa-to-linalg passes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
TosaToLinalg/
11 lines

Diff 399716

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines
}; };
} // namespace } // namespace
std::unique_ptr<Pass> mlir::tosa::createTosaToLinalg() { std::unique_ptr<Pass> mlir::tosa::createTosaToLinalg() {
return std::make_unique<TosaToLinalg>(); return std::make_unique<TosaToLinalg>();
} }
void mlir::tosa::addTosaToLinalgPasses(OpPassManager &pm) { void mlir::tosa::addTosaToLinalgPasses(OpPassManager &pm) {
// Optional decompositions are designed to benefit linalg.
pm.addNestedPass<FuncOp>(mlir::tosa::createTosaOptionalDecompositions()); pm.addNestedPass<FuncOp>(mlir::tosa::createTosaOptionalDecompositions());
pm.addNestedPass<FuncOp>(createTosaMakeBroadcastablePass());
pm.addNestedPass<FuncOp>(createTosaToLinalgNamed());
pm.addNestedPass<FuncOp>(mlir::createCanonicalizerPass()); pm.addNestedPass<FuncOp>(mlir::createCanonicalizerPass());
pm.addNestedPass<FuncOp>(createTosaMakeBroadcastablePass());
pm.addNestedPass<FuncOp>(createTosaToLinalg()); pm.addNestedPass<FuncOp>(tosa::createTosaMakeBroadcastablePass());
pm.addNestedPass<FuncOp>(tosa::createTosaToLinalgNamed());
pm.addNestedPass<FuncOp>(mlir::createCanonicalizerPass());
pm.addNestedPass<FuncOp>(tosa::createTosaMakeBroadcastablePass());
pm.addNestedPass<FuncOp>(tosa::createTosaToLinalg());
} }