Page MenuHomePhabricator
Differential D117160

[AArch64][GlobalISel] Implement combines for boolean G_SELECT->bitwise ops.
ClosedPublic
Actions

Authored by aemerson on Jan 12 2022, 2:24 PM.

Details

Reviewers
paquette
arsenm
Commits
rGb09e63bad1e5: [AArch64][GlobalISel] Implement combines for boolean G_SELECT->bitwise ops.
Summary

Needed to prevent regressions in a later patch. In general we're poor at dealing with saturating codegen.

Diff Detail

Event Timeline

aemerson created this revision.Jan 12 2022, 2:24 PM
Herald added subscribers: hiraditya, kristof.beyls, rovka. · View Herald TranscriptJan 12 2022, 2:24 PM
aemerson requested review of this revision.Jan 12 2022, 2:24 PM
Herald added a subscriber: wdng. · View Herald TranscriptJan 12 2022, 2:24 PM
arsenm added inline comments.Jan 12 2022, 2:59 PM
llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
5552–5553

These aren't allowed to fail

Harbormaster completed remote builds in B143018: Diff 399466.Jan 12 2022, 3:05 PM
aemerson updated this revision to Diff 399492.Jan 12 2022, 3:27 PM
aemerson added a child revision: D117166: [AArch64][GlobalISel] Optimize conjunctions of compares to conditional conmpares..
Harbormaster completed remote builds in B143033: Diff 399492.Jan 12 2022, 4:17 PM
arsenm accepted this revision.Jan 18 2022, 8:45 AM
This revision is now accepted and ready to land.Jan 18 2022, 8:45 AM
This revision was landed with ongoing or failed builds.Feb 20 2022, 1:12 AM
Closed by commit rGb09e63bad1e5: [AArch64][GlobalISel] Implement combines for boolean G_SELECT->bitwise ops. (authored by aemerson). · Explain Why
This revision was automatically updated to reflect the committed changes.
aemerson added a commit: rGb09e63bad1e5: [AArch64][GlobalISel] Implement combines for boolean G_SELECT->bitwise ops..

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
CodeGen/
GlobalISel/
3 lines
Target/
GlobalISel/
10 lines
lib/
CodeGen/
GlobalISel/
57 lines
test/
CodeGen/
AArch64/
GlobalISel/
182 lines
52 lines

Diff 410136

View Options

llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h

Loading...
View Options

llvm/include/llvm/Target/GlobalISel/Combine.td

Loading...
View Options

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Loading...
View Options

llvm/test/CodeGen/AArch64/GlobalISel/combine-select.mir

Loading...
View Options

llvm/test/CodeGen/AArch64/arm64-xaluo.ll

Loading...