[ifs] Added missing DT_STRSZ to the .dynamic section
ClosedPublic
Actions

Authored by haowei on Jan 11 2022, 2:56 PM.

Details

Reviewers

phosek
mcgrathr
jhenderson

Commits

rGa59bb21bf85e: [ifs] Added missing DT_STRSZ to the .dynamic section

Summary

This patch adds DT_STRSZ into the dynamic section, which was absent previously. This was a bug and caused failures in other tools.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

haowei created this revision.Jan 11 2022, 2:56 PM

Herald added a subscriber: hiraditya. · View Herald TranscriptJan 11 2022, 2:56 PM

haowei requested review of this revision.Jan 11 2022, 2:56 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 2:56 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

haowei mentioned this in D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.Jan 11 2022, 3:30 PM

Harbormaster completed remote builds in B142752: Diff 399092.Jan 11 2022, 3:44 PM

lgtm

This revision is now accepted and ready to land.Jan 11 2022, 5:20 PM

LGTM

haowei added a child revision: D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.Jan 11 2022, 9:21 PM

LGTM too.

This revision was landed with ongoing or failed builds.Feb 13 2022, 9:06 PM

Closed by commit rGa59bb21bf85e: [ifs] Added missing DT_STRSZ to the .dynamic section (authored by haowei). · Explain Why

This revision was automatically updated to reflect the committed changes.

haowei added a commit: rGa59bb21bf85e: [ifs] Added missing DT_STRSZ to the .dynamic section.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

InterfaceStub/

ELFObjHandler.cpp

1 line

test/

tools/

llvm-ifs/

write-stub.test

3 lines

Diff 408326

View Options

llvm/lib/InterfaceStub/ELFObjHandler.cpp